Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potentially broken [email protected] #454

Closed
mcollina opened this issue Dec 1, 2018 · 22 comments
Closed

potentially broken [email protected] #454

mcollina opened this issue Dec 1, 2018 · 22 comments
Assignees
Labels

Comments

@mcollina
Copy link
Member

mcollina commented Dec 1, 2018

A friend of mine sent an email to [email protected], but the vulnerability never popped up in hackerone.

Can somebody verify everything is working as expected? Thanks

@lirantal lirantal self-assigned this Dec 1, 2018
@lirantal
Copy link
Member

lirantal commented Dec 1, 2018

it's configured here: https://github.com/nodejs/email/blob/master/iojs.org/aliases.json#L44
/cc @nodejs/website and @reedloden from hackerone to see if there should be any change in that hackerone fwding address.

@lirantal lirantal added the bug label Dec 1, 2018
@rvagg
Copy link
Member

rvagg commented Dec 1, 2018

There's an additional layer of indirection via the Linux Foundation who manage @nodejs.org as a Google Apps account. We only control @iojs.org.

@reedloden
Copy link
Contributor

I just tested it, and it worked fine for me. You can test it yourself by sending an email to the address (it won't create a report until you follow the directions in the e-mail you get back).

Perhaps the person didn't notice the email reply and/or follow the directions in the email? Looks like this:

screenshot from 2018-12-01 09-10-29

@mcollina
Copy link
Member Author

mcollina commented Dec 1, 2018

I think we should document this wherever [email protected] is specified. It might get unnoticed.

(everything was sorted btw)

@lirantal
Copy link
Member

lirantal commented Dec 1, 2018

@rvagg probably best to further update any documentation necessary in https://github.com/nodejs/email ?

@rvagg
Copy link
Member

rvagg commented Dec 2, 2018

nodejs/email#126

@mcollina mcollina closed this as completed Dec 3, 2018
@indutny indutny reopened this Apr 10, 2019
@indutny
Copy link
Member

indutny commented Apr 10, 2019

The mailing list appears to be broken again: envoyproxy/envoy#5155 (comment) . The report was sent two times to the mailing list, but is nowhere to be found on the HackerOne! 😭

@reedloden
Copy link
Contributor

@indutny I just tested it, and it's working fine. 🤷‍♂️

Again, e-mailing will not immediately create a report. You will receive a reply back from HackerOne with a link to finalize the report submission via the web portal. Perhaps they were overlooking the reply back?

@htuch
Copy link

htuch commented Apr 10, 2019

@reedloden I just checked my e-mail (including spam) and see nothing from HackerOne. Is there any way to get some audit information from HackerOne on what happened here?

@reedloden
Copy link
Contributor

@reedloden I just checked my e-mail (including spam) and see nothing from HackerOne. Is there any way to get some audit information from HackerOne on what happened here?

Can you provide the e-mail address you used? If you don't want to post it here, feel free to e-mail me at reed [at] hackerone.com. Would be happy to take a look at logs.

@reedloden
Copy link
Contributor

DMARC strikes again.

The e-mail was received, but it wasn't parsed correctly because the From was [email protected] due to Google Groups rewriting the e-mail due to @htuch's e-mail domain have a DMARC policy of p=reject.

The e-mail went like this:
@htuch's email provider --> Google Group ([email protected]) --> Mailgun ([email protected]) --> HackerOne ([email protected]).

We'll see what we can do on our side, but a fix on the Node.js side would be to directly forward mail rather than going through any intermediates that rewrite the From header.

@rvagg
Copy link
Member

rvagg commented Apr 12, 2019

I've put in a request to the LF to have [email protected] changed to a direct forward to [email protected].

This is a little bit sad because the intention of the iojs.org domain is that we control that and don't need to defer to the Linux Foundation who control nodejs.org.

@reedloden
Copy link
Contributor

reedloden commented Apr 12, 2019 via email

@rvagg
Copy link
Member

rvagg commented Apr 12, 2019

The Linux Foundation helpdesk has gone Jira for handling requests so my request got bounced and and you now need to log in to get anything done with them. I have very limited patience when dealing with the LF so I'm going to ask @MylesBorins or @mhdawson to please handle these if they don't mind.

Myles & Michael, please see the additional request above ^ [email protected] should go to [email protected].

@mhdawson
Copy link
Member

I submitted the Jira request and it has been completed.

@mhdawson
Copy link
Member

But just saw the new request. New request: https://jira.linuxfoundation.org/servicedesk/customer/portal/2/IT-16269

@rvagg
Copy link
Member

rvagg commented Apr 16, 2019

thanks @mhdawson!

@mhdawson
Copy link
Member

mhdawson commented Apr 16, 2019

The response for the additional request was:

Hello,

[email protected] already goes to 
[email protected]. 

@sam-github
Copy link
Contributor

@mhdawson https://jira.linuxfoundation.org/servicedesk/customer/portal/2/IT-16269 isn't viewable publically. Its good to have it there for completion, but just mentioning here because its not possible, or at least not for me, probably others, to see what state the request is in.

@sam-github
Copy link
Contributor

So, is this all working now? Can the issue be closed?

@htuch
Copy link

htuch commented Jun 26, 2019

@sam-github I guess a question is "how do we know if this is continually working?". I almost think something like a periodic prober would be warranted given the history of this issue. That said, I'm not a member of Node.JS security WG, so feel free to close if you wish.

@sam-github
Copy link
Contributor

@htuch nodejs/build have trouble maintaining current infrastructure, I don't think we have capacity to add more, but if you'd like to join the build WG and maintain such a thing, or help in any other way, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants