-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tap13 from upstream, reapply py3 compatibility PR #18
Conversation
@rajcze @jbergstroem PTAL I had to reapply py3 compat, and the builtin tests are failing:
Its odd that exit code is |
Pulled lastest from upstream: $ curl -o tap2junit/tap13.py \ https://bitbucket.org/fedoraqa/pytap13/raw/master/pytap13.py Note that the upstream version is now under the Apache License. Fixes nodejs/admin#413
Floating patch for Python 3 support. PR-URL: #5 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matt (IPv4) Cowley <[email protected]>
a9e3828
to
cd0342e
Compare
@jbergstroem any thoughts? the new version has a license that doesn't cause any IP issues, do you think its functional? |
Happy to merge it. I haven't had the time to look at the failing tests though.. |
@cclauss do you have any interest in figuring out how to make the updated tap13 work/pass tests? |
Replaced by #19 |
and
Fixes nodejs/admin#413