Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to how the wasm is loaded in #1183 have accidentally changed the order of simd/other builds.
You can see in the diff, originally the
This makes sense because the simd build should throw when it isnt supported, and the catch loads the basic version.
Currently no one will be using the simd version.
This PR changes the order back, so that simd is loaded first, and on error we can the basic version.
I've also inlined the
require
call to the base64 JS module, this way most of the time the text of the basic version doesnt need to be loaded.