Make call to onBodySent conditional in RetryHandler

[MzUgM]

This relates to...

N/A

Rationale

The RetryHandler always sends chunks to onBodySent but onBodySent is optional according to the current type definition (types/dispatcher.d.ts#L220). It also causes a conflict when using undici.request() as the RequestHandler does not implement onBodySent.

Changes

• exporting RequestHandler for easier testing
• making the call from RetryHandler.onBodySent to the next handler conditional on the existence of an onBodySent

Features

N/A

Bug Fixes

Without this change, an error would occur on requests with a body (POST, PUT) when using the RetryHandler.

TypeError: this.handler.onBodySent is not a function
      at RetryHandler.onBodySent (/p/token-dispatcher/node_modules/undici/lib/handler/RetryHandler.js:99:25)
      at Request.onBodySent (/p/trecentotredici/node_modules/undici/lib/core/request.js:233:31)
      at write (/p/trecentotredici/node_modules/undici/lib/client.js:1623:13)
      at _resume (/p/trecentotredici/node_modules/undici/lib/client.js:1467:29)
      at resume (/p/trecentotredici/node_modules/undici/lib/client.js:1341:3)
      at connect (/p/trecentotredici/node_modules/undici/lib/client.js:1326:3)

Breaking Changes and Deprecations

N/A

Status

• I have read and agreed to the Developer's Certificate of Origin
• Tested
• [S] Benchmarked (optional)
• [S] Documented
• Review ready
• In review
• Merge ready

[mcollina]

Lgtm

[codecov-commenter]

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (8a8079b) 85.45%.
Report is 117 commits behind head on main.

Files	Patch %	Lines
lib/handler/RetryHandler.js	73.91%	30 Missing ⚠️
lib/fetch/index.js	64.51%	11 Missing ⚠️
lib/fetch/headers.js	88.63%	5 Missing ⚠️
lib/api/readable.js	80.00%	4 Missing ⚠️
lib/client.js	92.10%	3 Missing ⚠️
lib/core/util.js	90.47%	2 Missing ⚠️
lib/fetch/request.js	90.00%	2 Missing ⚠️
lib/core/request.js	97.56%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2478      +/-   ##
==========================================
- Coverage   85.54%   85.45%   -0.10%     
==========================================
  Files          76       77       +1     
  Lines        6858     7056     +198     
==========================================
+ Hits         5867     6030     +163     
- Misses        991     1026      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metcoder95]

Good catch!