Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove own sort logic #2834

Merged
merged 1 commit into from
Feb 24, 2024
Merged

refactor: remove own sort logic #2834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions benchmarks/sort.mjs
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions lib/web/fetch/headers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ const {
} = require('./util')
const { webidl } = require('./webidl')
const assert = require('node:assert')
const { sort } = require('./sort')

const kHeadersMap = Symbol('headers map')
const kHeadersSortedMap = Symbol('headers map sorted')
Expand Down Expand Up @@ -328,7 +327,7 @@ class HeadersList {
// 3.2.2. Assert: value is non-null.
assert(value !== null)
}
return sort(array, compareHeaderName)
return array.sort(compareHeaderName)
}
}
}
Expand Down
187 changes: 0 additions & 187 deletions lib/web/fetch/sort.js
View file
Open in desktop

This file was deleted.

90 changes: 0 additions & 90 deletions test/fetch/sort.js
View file
Open in desktop

This file was deleted.

Loading