Merge branch 'hotfix/0.2.2'

noeldelgado · Mar 2, 2020 · 10744e2 · 10744e2
2 parents 9385967 + 88153bb
commit 10744e2
Show file tree

Hide file tree

Showing 9 changed files with 57 additions and 28 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,10 +2,20 @@
 
 ## [Unreleased]
 
-## [0.2.1] - [#6](../../pull/6) - 2020-03-01
+## [0.2.2] - [#6](../../pull/6) - 2020-03-02
+### Added
+- Focus style for inputs [`7bbbb31`](https://github.com/noeldelgado/yacc/commit/7bbbb315444100164eb1690211343d1b25572290)
+- Twitter summary card [`a4d1cda`](https://github.com/noeldelgado/yacc/commit/a4d1cda00b63d7a47ad73f8f033e27388384ce07)
+
+### Fixed
+- alpha=0 text constrast [`1388cea`](https://github.com/noeldelgado/yacc/commit/1388cea18a8e51d99431c95847ff24b99356d283)
+- aria-hidden for buttons with svg icons and typo [`bdd3ca6`](https://github.com/noeldelgado/yacc/commit/bdd3ca6570b161648952c01e221a23e54936aed7)
+
+## [0.2.1] - 2020-03-01
 ### Changed
-- Fix feColorMatrix whitespace [`185a02e`](https://github.com/noeldelgado/yacc/commit/185a02e41a8c3b97454376dd1f3b964c3749e6bc)
 - Add new supported models to page description and default share text for twitter [`8c1c0fd`](https://github.com/noeldelgado/yacc/commit/8c1c0fddce26204dd410a429bc1040979a5e44c8)
+### Fixed
+- feColorMatrix whitespace [`185a02e`](https://github.com/noeldelgado/yacc/commit/185a02e41a8c3b97454376dd1f3b964c3749e6bc)
 
 ## [0.2.0] - [#5](../../pull/5) - 2020-03-01
 ### Added
@@ -17,25 +27,29 @@
 - new CSS Variables `--cc-main-solid-color`
 - Mobile: apple-mobile-web-app-status-bar-style => black-translucent [`0330ffe`](https://github.com/noeldelgado/yacc/commit/0330ffeb8113aa2a10b20156fcee5ba7fd01a8d7)
 - HSV, CMKYK and LAB support [`a4560e6`](https://github.com/noeldelgado/yacc/commit/a4560e6b055b47060c033d98ba4068340c519eb8)
+- Initial random color [`b663608`](https://github.com/noeldelgado/yacc/commit/b663608b3d51476c0482b6e647aa258c8384dac8)
 
 ### Changed
-- Fix Firefox 100% width input overflow [`c4c80f0`](https://github.com/noeldelgado/yacc/commit/c4c80f0eb412951ec4efd1e6376ebc156b557261)
-- Fix manually changing hash not updating UI [`6e1f71f`](https://github.com/noeldelgado/yacc/commit/6e1f71f168cba2f162780f0a17e6ddb23c6f4b04)
 - Update autoprefixer:browsers 'last 1 version' [`a487a4d`](https://github.com/noeldelgado/yacc/commit/a487a4d95fd0899874149c5ea603320471224ce3)
-- Remove github-corner [`4e0dd25`](https://github.com/noeldelgado/yacc/commit/4e0dd25a11c4f0585b7b346a26d485bbddf70875)
-- Initial random color [`b663608`](https://github.com/noeldelgado/yacc/commit/b663608b3d51476c0482b6e647aa258c8384dac8)
+
+### Removed
+- github-corner [`4e0dd25`](https://github.com/noeldelgado/yacc/commit/4e0dd25a11c4f0585b7b346a26d485bbddf70875)
+
+### Fixed
+- Manually changing hash not updating UI [`6e1f71f`](https://github.com/noeldelgado/yacc/commit/6e1f71f168cba2f162780f0a17e6ddb23c6f4b04)
+- Firefox 100% width input overflow [`c4c80f0`](https://github.com/noeldelgado/yacc/commit/c4c80f0eb412951ec4efd1e6376ebc156b557261)
 
 ## [0.1.3] - [#4](../../pull/4) - 2020-02-18
-### Changed
+### Fixed
 - Fix site.webmanifest paths
 
 ## [0.1.2] - [#3](../../pull/3) - 2020-02-18
-### Changed
-- Fix site.webmanifest paths
-- Fix history navigation
+### Fixed
+- site.webmanifest paths
+- History navigation
 
 ## [0.1.1] - [#2](../../pull/2) - 2020-02-18
-### Changed
+### Fixed
 - Fix assets path
 
 ## [0.1.0] - [#1](../../pull/1) - 2020-02-18
@@ -70,7 +84,8 @@
 ## 2013-10-03
 - Initial release
 
-[Unreleased]: https://github.com/noeldelgado/yacc/compare/v0.2.1...HEAD
+[Unreleased]: https://github.com/noeldelgado/yacc/compare/v0.2.2...HEAD
+[0.2.2]: https://github.com/noeldelgado/yacc/compare/v0.2.1...v0.2.2
 [0.2.1]: https://github.com/noeldelgado/yacc/compare/v0.2.0...v0.2.1
 [0.2.0]: https://github.com/noeldelgado/yacc/compare/v0.1.3...v0.2.0
 [0.1.3]: https://github.com/noeldelgado/yacc/compare/v0.1.2...v0.1.3

diff --git a/README.md b/README.md
@@ -1,6 +1,6 @@
 ## yet another color converter
 
-Convert HEX/RGB/HSL/HWB color models plus feColorMatrix’s values.
+Convert HEX, RGB, HSL, HWB, HSV, CMKYK, LAB color models plus feColorMatrix’s values.
 
 https://noeldelgado.github.io/yacc/
 

diff --git a/build/css/main.css b/build/css/main.css
diff --git a/build/js/main.js b/build/js/main.js
diff --git a/index.html b/index.html
@@ -3,11 +3,16 @@
 <head>
   <meta charset="utf-8" />
   <title>Yet another color converter</title>
-  <meta name="description" content="Convert HEX/RGB/HSL/HWB/HSV/CMYK/LAB color models plus feColorMatrix’s values">
+  <meta name="description" content="Convert HEX, RGB, HSL, HWB, HSV, CMYK, LAB color models plus feColorMatrix’s values">
   <meta name="language" content="en">
   <meta name="viewport" content="width=device-width, initial-scale=1.0">
   <meta name="apple-mobile-web-app-status-bar-style" content="black-translucent">
   <meta name="theme-color" content="#ffffff">
+  <meta name="twitter:card" content="summary">
+  <meta name="twitter:creator" content="@pixelia_me">
+  <meta name="twitter:title" content="Yet another color converter">
+  <meta name="twitter:description" content="Convert HEX, RGB, HSL, HWB, HSV, CMYK, LAB color models plus feColorMatrix’s values">
+  <meta name="twitter:image" content="https://noeldelgado.github.io/yacc/public/images/og-yacc-300x157.jpg">
   <link rel="preload" href="build/css/main.css" as="style">
   <link rel="preload" href="build/js/main.js" as="script">
   <link rel="dns-prefetch" href="https://fonts.googleapis.com">
@@ -19,10 +24,10 @@
   <link rel="stylesheet" href="build/css/main.css" media="all">
 </head>
 <body class="df">
-  <svg width="0" height="0" style="position:absolute"><symbol viewBox="0 0 24 24" id="svg-file_copy-outlined-24px" xmlns="http://www.w3.org/2000/svg"><path d="M0 0h24v24H0V0z" fill="none"/><path d="M16 1H4c-1.1 0-2 .9-2 2v14h2V3h12V1zm-1 4H8c-1.1 0-1.99.9-1.99 2L6 21c0 1.1.89 2 1.99 2H19c1.1 0 2-.9 2-2V11l-6-6zM8 21V7h6v5h5v9H8z"/></symbol></svg>
+  <svg width="0" height="0" aria-hidden="true" style="position:absolute"><symbol viewBox="0 0 24 24" id="svg-file_copy-outlined-24px" xmlns="http://www.w3.org/2000/svg"><path d="M0 0h24v24H0V0z" fill="none"/><path d="M16 1H4c-1.1 0-2 .9-2 2v14h2V3h12V1zm-1 4H8c-1.1 0-1.99.9-1.99 2L6 21c0 1.1.89 2 1.99 2H19c1.1 0 2-.9 2-2V11l-6-6zM8 21V7h6v5h5v9H8z"/></symbol></svg>
   <div class="root">
     <header class="df aic">
-      <svg width="48" height="48" viewBox="0 0 64 64" class="mr1">
+      <svg width="48" height="48" viewBox="0 0 64 64" class="mr1" aria-hidden="true">
         <path d="M0,0 a1,1 0 0,0 64,0" fill="white" transform="scale(1 -1) translate(0 -32)" />
         <path d="M0,32 a1,1 0 0,0 64,0" fill="black" />
       </svg>
@@ -136,8 +141,10 @@
         </li>
       </ul>
       <div>
-        <button class="cc-btn" data-js-copy-to-clipboard-btn data-copy="value:[data-js-fecolormatrix-input]" disabled>
-          <svg width="16" height="16"><use xlink:href="#svg-file_copy-outlined-24px"></use></svg>
+        <button class="cc-btn" data-js-copy-to-clipboard-btn data-copy="value:[data-js-fecolormatrix-input]" aria-label="Copy feColorMatrix to clipboard" disabled>
+          <svg width="16" height="16" aria-hidden="true">
+            <use xlink:href="#svg-file_copy-outlined-24px"></use>
+          </svg>
           <span>feColorMatrix’s values</span>
           <textarea data-js-fecolormatrix-input rows="4" readonly style="display: none;"></textarea>
         </button>
@@ -146,21 +153,23 @@
     <footer>
       <div>
         <button data-js-random-btn class="cc-btn-icon" aria-label="Generate random color" disabled>
-          <svg xmlns="http://www.w3.org/2000/svg" width="32" height="32" viewBox="0 0 24 24" aria-hidden="true">
+          <svg width="32" height="32" viewBox="0 0 24 24" aria-hidden="true">
             <rect width="24" height="24" fill="rgba(0,0,0,0)"/>
             <path d="M10.59 9.17L6.12 4.7c-.39-.39-1.02-.39-1.41 0-.39.39-.39 1.02 0 1.41l4.46 4.46 1.42-1.4zm4.76-4.32l1.19 1.19L4.7 17.88c-.39.39-.39 1.02 0 1.41.39.39 1.02.39 1.41 0L17.96 7.46l1.19 1.19c.31.31.85.09.85-.36V4.5c0-.28-.22-.5-.5-.5h-3.79c-.45 0-.67.54-.36.85zm-.52 8.56l-1.41 1.41 3.13 3.13-1.2 1.2c-.31.31-.09.85.36.85h3.79c.28 0 .5-.22.5-.5v-3.79c0-.45-.54-.67-.85-.35l-1.19 1.19-3.13-3.14z" />
           </svg>
         </button>
         <button data-js-colorpicker-btn class="cc-btn-icon" aria-label="Open color picker" disabled>
-          <svg xmlns="http://www.w3.org/2000/svg" width="32" height="32" viewBox="0 0 24 24" aria-hidden="true">
+          <svg width="32" height="32" viewBox="0 0 24 24" aria-hidden="true">
             <path d="M0 0h24v24H0V0z" fill="none"/>
             <path d="M17.66 5.41l.92.92-2.69 2.69-.92-.92 2.69-2.69M17.67 3c-.26 0-.51.1-.71.29l-3.12 3.12-1.93-1.91-1.41 1.41 1.42 1.42L3 16.25V21h4.75l8.92-8.92 1.42 1.42 1.41-1.41-1.92-1.92 3.12-3.12c.4-.4.4-1.03.01-1.42l-2.34-2.34c-.2-.19-.45-.29-.7-.29zM6.92 19L5 17.08l8.06-8.06 1.92 1.92L6.92 19z"/>
           </svg>
         </button>
       </div>
       <div class="footer__info">
         <a class="tdn" href="https://github.com/noeldelgado/yacc" rel="noopener noreferrer" aria-label="View source on GitHub">
-          <svg class="mr1" xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 24 24"><path d="M12 0c-6.626 0-12 5.373-12 12 0 5.302 3.438 9.8 8.207 11.387.599.111.793-.261.793-.577v-2.234c-3.338.726-4.033-1.416-4.033-1.416-.546-1.387-1.333-1.756-1.333-1.756-1.089-.745.083-.729.083-.729 1.205.084 1.839 1.237 1.839 1.237 1.07 1.834 2.807 1.304 3.492.997.107-.775.418-1.305.762-1.604-2.665-.305-5.467-1.334-5.467-5.931 0-1.311.469-2.381 1.236-3.221-.124-.303-.535-1.524.117-3.176 0 0 1.008-.322 3.301 1.23.957-.266 1.983-.399 3.003-.404 1.02.005 2.047.138 3.006.404 2.291-1.552 3.297-1.23 3.297-1.23.653 1.653.242 2.874.118 3.176.77.84 1.235 1.911 1.235 3.221 0 4.609-2.807 5.624-5.479 5.921.43.372.823 1.102.823 2.222v3.293c0 .319.192.694.801.576 4.765-1.589 8.199-6.086 8.199-11.386 0-6.627-5.373-12-12-12z"/></svg>
+          <svg class="mr1" width="16" height="16" viewBox="0 0 24 24" aria-hidden="true">
+            <path d="M12 0c-6.626 0-12 5.373-12 12 0 5.302 3.438 9.8 8.207 11.387.599.111.793-.261.793-.577v-2.234c-3.338.726-4.033-1.416-4.033-1.416-.546-1.387-1.333-1.756-1.333-1.756-1.089-.745.083-.729.083-.729 1.205.084 1.839 1.237 1.839 1.237 1.07 1.834 2.807 1.304 3.492.997.107-.775.418-1.305.762-1.604-2.665-.305-5.467-1.334-5.467-5.931 0-1.311.469-2.381 1.236-3.221-.124-.303-.535-1.524.117-3.176 0 0 1.008-.322 3.301 1.23.957-.266 1.983-.399 3.003-.404 1.02.005 2.047.138 3.006.404 2.291-1.552 3.297-1.23 3.297-1.23.653 1.653.242 2.874.118 3.176.77.84 1.235 1.911 1.235 3.221 0 4.609-2.807 5.624-5.479 5.921.43.372.823 1.102.823 2.222v3.293c0 .319.192.694.801.576 4.765-1.589 8.199-6.086 8.199-11.386 0-6.627-5.373-12-12-12z"/>
+          </svg>
           <span>View Source</span>
         </a>
         <a class="tdn" href="https://twitter.com/share?text=Convert%20HEX%2FRGB%2FHSL%2FHWB%2FHSV%2FCMYK%2FLAB%2FfeColorMatrix%20with%20yet-another-color-converter%20by%20%40pixelia_me&url=https%3A%2F%2Fnoeldelgado.github.io%2Fyacc%2F" target="_blank" rel="noopener noreferrer" aria-label="Share tool on Twitter. Will open in a new window.">
@@ -174,7 +183,7 @@
   </div>
   <div class="cc-by">
     <a class="tdn" href="http://pixelia.me" aria-label="Visit author’s website">
-      <svg height="12" viewBox="0 0 57 30" arial-hidden="true">
+      <svg height="12" viewBox="0 0 57 30" aria-hidden="true">
         <path d="M28.1312,9.5341 C29.7966,9.5341 32.1025,10.627 34.248,12.368 C49.3297,11.5836 53.8793,-0.4796 55.5773,0.6783 C57.8326,3.2476 50.8638,16.3535 39.4,19.088 C39.8655,20.2628 40.1364,21.4786 40.1364,22.6983 C40.1364,25.9478 38.837,26.7409 36.7281,28.8974 L36.704,28.824 C36.4799,29.0276 36.208,29.2318 35.8945,29.4 C35.8945,29.4 36.1346,27.0065 34.9341,26.7672 C34.9341,26.7672 34.3739,27.4054 33.0133,27.2459 C32.8532,25.8896 32.293,25.4109 32.1329,25.3311 C31.4126,25.4109 30.9324,26.5278 30.132,26.5278 C29.8,26.1969 29.5184,25.5615 29.312,24.972 C29.0201,25.4221 28.6036,26.1128 28.2512,26.2885 C27.8796,26.2885 27.1476,25.2858 26.836,24.832 C26.6262,25.4581 26.3285,26.1707 25.9702,26.5278 C25.1699,26.5278 24.6896,25.4109 23.9694,25.3311 C23.8093,25.4109 23.249,25.8896 23.089,27.2459 C21.7284,27.4054 21.1681,26.7672 21.1681,26.7672 C19.9676,27.0065 20.2077,29.4 20.2077,29.4 C19.6122,29.0804 19.1739,28.6307 18.908,28.304 L18.8667,28.3947 C17.1544,26.3262 16.1259,25.5896 16.1259,22.6983 C16.1259,21.4938 16.3637,20.2895 16.784,19.128 C5.2094,16.4922 -1.8448,3.2615 0.4227,0.6783 C2.119,-0.4785 6.6627,11.5578 21.708,12.364 C23.8143,10.6244 26.1724,9.5341 28.1312,9.5341 Z M28.8514,20.3048 C28.8514,20.3048 30.4121,21.7409 32.213,21.7409 C34.0137,21.7409 35.3343,19.3474 35.3343,19.3474 L28.8514,20.3048 Z M20.6879,19.3474 C20.6879,19.3474 22.2486,21.7409 24.0494,21.7409 C25.8502,21.7409 27.1707,20.3048 27.1707,20.3048 L20.6879,19.3474 Z" fill-rule="evenodd"/>
       </svg>
     </a>

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "private": true,
   "name": "yacc",
-  "version": "0.2.1",
+  "version": "0.2.2",
   "scripts": {
     "start": "npm run watch",
     "watch": "tarima watch src",

diff --git a/public/images/og-yacc-300x157.jpg b/public/images/og-yacc-300x157.jpg
diff --git a/src/css/lib/components/inputs.css b/src/css/lib/components/inputs.css
@@ -9,6 +9,11 @@ input.cc-input {
   outline: none;
   text-overflow: ellipsis;
 
+  &:focus {
+    text-decoration: underline;
+    text-decoration-color: var(--cc-border-color);
+  }
+
   &:invalid,
   &[aria-invalid="true"] {
     text-decoration: underline wavy red;

diff --git a/src/js/lib/app.js b/src/js/lib/app.js
@@ -228,9 +228,9 @@ export default class App {
         const cmyk = app.color.cmyk().round().array().toString();
         const lab = app.color.lab().round().array().toString();
 
-        const isLight = app.color.isLight();
-        const textColor = app.color.mix(Color(isLight? '#000' : '#fff'), 0.8);
-        const borderColor = app.color.mix(Color(isLight? '#000' : '#fff'), 0.2);
+        const mix = (app.color.isDark() && app.color.alpha() > 0.5)? '#fff' : '#000';
+        const textColor = app.color.mix(Color(mix), 0.8);
+        const borderColor = app.color.mix(Color(mix), 0.2);
 
         if (preventElementUpdate !== app.ui.hexInput.element)
             app.ui.hexInput.setValue(hexa.replace('#', ''));