This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
feat: allow updating an empty CRS buffer #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
graceful-empty-crs-update
branch
from
a41644d
to
82615c6
Compare
phated
suggested changes
May 22, 2023
There was a problem hiding this comment.
From a caller/callee perspective, I think it's wrong to ever call the update function with an empty vector. The reason that an empty vector is used in Nargo is to make the type system happy; otherwise we'd be dealing with options in a lot of places I didn't want to.
There may be a case for only having a get_or_update_crs API but that'd take an Option for CRS and the is_empty check would still need to exist in Nargo.
|
True, an |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves noir-lang/noir#1348 (comment)