Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

feat: Update Arkworks' dependencies on acir_field #69

Merged
merged 5 commits into from
Feb 10, 2023
Merged

feat: Update Arkworks' dependencies on acir_field #69

merged 5 commits into from
Feb 10, 2023

Conversation

ilitteri
Copy link
Contributor

@ilitteri ilitteri commented Feb 2, 2023 •
edited
Loading

Related issue(s)

Resolves #68

Description

Summary of changes

Update Arkworks' dependencies on acir_field's Cargo.toml.

Dependency additions / changes

  • Update ark-bn254 from 0.3.0 to 0.4.0.
  • Update ark-bls12-381 from 0.3.0 to 0.4.0.
  • Update ark-ff from 0.3.0 to 0.4.0.
  • Add ark-serialize 0.4.0.
  • Remove ark-bn254 from dev-dependencies.

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

The additional context was provided in #68

@ilitteri
Update field element serialization
1e121e9 
`to_bytes!` macro is not available anymore in `ark-ff`
@ilitteri
Update FieldElement::pow
ca200de
@ilitteri
Update use of F constants
0da60c0
@ilitteri
Remove unused import
d1365c1
@ilitteri
Remove repeated dev-dependency
7ca9177 
`ark-bn254` with the `curve` feature is already a dependency so it is not needed as a dev-dependency unless it uses other features than the regular dependency
@ilitteri ilitteri changed the title Update Arkworks's dependencies on acir_field Update Arkworks' dependencies on acir_field Feb 2, 2023
@kevaundray kevaundray changed the title Update Arkworks' dependencies on acir_field feat: Update Arkworks' dependencies on acir_field Feb 3, 2023
@kevaundray kevaundray self-requested a review February 3, 2023 23:36
@kevaundray
Copy link
Contributor

This looks good, thanks! Just to make sure it doesn't break anything, I'll run tests against the noir compiler before merging

@ilitteri
Copy link
Contributor Author

ilitteri commented Feb 4, 2023

This looks good, thanks! Just to make sure it doesn't break anything, I'll run tests against the noir compiler before merging

Nice! Let me know if there is something more for me to do in the case that the tests don't pass

@kevaundray kevaundray merged commit 65d6130 into noir-lang:master Feb 10, 2023
TomAFrench added a commit to TomAFrench/acvm that referenced this pull request Feb 10, 2023
@TomAFrench
Merge branch 'master' into jcf/reorganise_compiler
a3a04db 
* master:
  feat: Update Arkworks' dependencies on `acir_field` (noir-lang#69)
  add tests for `from_hex` and `to_hex` (noir-lang#85)
  improve field formatting (noir-lang#84)
  chore(ci): Leverage reusable workflows (noir-lang#81)
  fix clippy (noir-lang#82)
  0.4.1 Release
  remove duplicated match statement for Directive::Log (noir-lang#79)
  0.4.0 Release
  update changelog
  feat(acvm): Directive for sorting networks (noir-lang#77)
  feat: Preprocess methods for ACVM interface  (noir-lang#71)
  expose acir_field through acir (noir-lang#75)
  chore(acvm): rename remaining references to gadget calls (noir-lang#76)
  feat: Add Log Directive (noir-lang#61)
  blackbox to black_box (noir-lang#72)
  feat(ci)!: add spellchecker (noir-lang#73)
TomAFrench added a commit that referenced this pull request Feb 10, 2023
@TomAFrench
Merge branch 'master' into jcf/reorganise_compiler
c9aaf40 
* master:
  feat: Update Arkworks' dependencies on `acir_field` (#69)
  add tests for `from_hex` and `to_hex` (#85)
  improve field formatting (#84)
  chore(ci): Leverage reusable workflows (#81)
  fix clippy (#82)
  0.4.1 Release
  remove duplicated match statement for Directive::Log (#79)
  0.4.0 Release
  update changelog
  feat(acvm): Directive for sorting networks (#77)
  feat: Preprocess methods for ACVM interface  (#71)
  expose acir_field through acir (#75)
  chore(acvm): rename remaining references to gadget calls (#76)
  feat: Add Log Directive (#61)
  blackbox to black_box (#72)
  feat(ci)!: add spellchecker (#73)
TomAFrench added a commit that referenced this pull request Feb 10, 2023
@TomAFrench
Merge branch 'master' into jcf/reorganise_compiler
33ede01 
* master:
  feat: Update Arkworks' dependencies on `acir_field` (#69)
  add tests for `from_hex` and `to_hex` (#85)
  improve field formatting (#84)
  chore(ci): Leverage reusable workflows (#81)
  fix clippy (#82)
  0.4.1 Release
  remove duplicated match statement for Directive::Log (#79)
  0.4.0 Release
  update changelog
  feat(acvm): Directive for sorting networks (#77)
  feat: Preprocess methods for ACVM interface  (#71)
  expose acir_field through acir (#75)
  chore(acvm): rename remaining references to gadget calls (#76)
  feat: Add Log Directive (#61)
  blackbox to black_box (#72)
  feat(ci)!: add spellchecker (#73)
TomAFrench added a commit that referenced this pull request Feb 10, 2023
@TomAFrench
Merge branch 'master' into jcf/reorganise_compiler
c701a46 
* master:
  feat: Update Arkworks' dependencies on `acir_field` (#69)
  add tests for `from_hex` and `to_hex` (#85)
  improve field formatting (#84)
  chore(ci): Leverage reusable workflows (#81)
  fix clippy (#82)
  0.4.1 Release
  remove duplicated match statement for Directive::Log (#79)
  0.4.0 Release
  update changelog
  feat(acvm): Directive for sorting networks (#77)
  feat: Preprocess methods for ACVM interface  (#71)
  expose acir_field through acir (#75)
  chore(acvm): rename remaining references to gadget calls (#76)
  feat: Add Log Directive (#61)
  blackbox to black_box (#72)
  feat(ci)!: add spellchecker (#73)
@github-actions github-actions bot mentioned this pull request Feb 11, 2023
Merged
@ilitteri ilitteri deleted the arkworks_update branch February 17, 2023 14:04
@github-actions github-actions bot mentioned this pull request Apr 28, 2023
Merged
kobyhallx pushed a commit that referenced this pull request Jul 26, 2023
@TomAFrench
chore!: update to ACVM 0.19.0 (#69)
7f49911
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevaundray kevaundray Awaiting requested review from kevaundray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Arkworks' dependencies on acir_field
2 participants
@ilitteri @kevaundray