This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
feat: Add Log Directive #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Out of scope, but noting for reference: We won't be able to have the equivalent of templating just yet. ie For that LogInfo would probably need to be Recurisvely defined. We can open up a future issue/PR for this |
kevaundray
approved these changes
Feb 4, 2023
TomAFrench
added a commit
to TomAFrench/acvm
that referenced
this pull request
Feb 10, 2023
* master: feat: Update Arkworks' dependencies on `acir_field` (noir-lang#69) add tests for `from_hex` and `to_hex` (noir-lang#85) improve field formatting (noir-lang#84) chore(ci): Leverage reusable workflows (noir-lang#81) fix clippy (noir-lang#82) 0.4.1 Release remove duplicated match statement for Directive::Log (noir-lang#79) 0.4.0 Release update changelog feat(acvm): Directive for sorting networks (noir-lang#77) feat: Preprocess methods for ACVM interface (noir-lang#71) expose acir_field through acir (noir-lang#75) chore(acvm): rename remaining references to gadget calls (noir-lang#76) feat: Add Log Directive (noir-lang#61) blackbox to black_box (noir-lang#72) feat(ci)!: add spellchecker (noir-lang#73)
TomAFrench
added a commit
that referenced
this pull request
Feb 10, 2023
* master: feat: Update Arkworks' dependencies on `acir_field` (#69) add tests for `from_hex` and `to_hex` (#85) improve field formatting (#84) chore(ci): Leverage reusable workflows (#81) fix clippy (#82) 0.4.1 Release remove duplicated match statement for Directive::Log (#79) 0.4.0 Release update changelog feat(acvm): Directive for sorting networks (#77) feat: Preprocess methods for ACVM interface (#71) expose acir_field through acir (#75) chore(acvm): rename remaining references to gadget calls (#76) feat: Add Log Directive (#61) blackbox to black_box (#72) feat(ci)!: add spellchecker (#73)
TomAFrench
added a commit
that referenced
this pull request
Feb 10, 2023
* master: feat: Update Arkworks' dependencies on `acir_field` (#69) add tests for `from_hex` and `to_hex` (#85) improve field formatting (#84) chore(ci): Leverage reusable workflows (#81) fix clippy (#82) 0.4.1 Release remove duplicated match statement for Directive::Log (#79) 0.4.0 Release update changelog feat(acvm): Directive for sorting networks (#77) feat: Preprocess methods for ACVM interface (#71) expose acir_field through acir (#75) chore(acvm): rename remaining references to gadget calls (#76) feat: Add Log Directive (#61) blackbox to black_box (#72) feat(ci)!: add spellchecker (#73)
TomAFrench
added a commit
that referenced
this pull request
Feb 10, 2023
* master: feat: Update Arkworks' dependencies on `acir_field` (#69) add tests for `from_hex` and `to_hex` (#85) improve field formatting (#84) chore(ci): Leverage reusable workflows (#81) fix clippy (#82) 0.4.1 Release remove duplicated match statement for Directive::Log (#79) 0.4.0 Release update changelog feat(acvm): Directive for sorting networks (#77) feat: Preprocess methods for ACVM interface (#71) expose acir_field through acir (#75) chore(acvm): rename remaining references to gadget calls (#76) feat: Add Log Directive (#61) blackbox to black_box (#72) feat(ci)!: add spellchecker (#73)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves log statement issue in noir-lang repo: noir-lang/noir#383
Description
This includes a Log directive and the logic in the PWG for solving it.
Summary of changes
I added a Log directive that takes a LogInfo enum. This enum can either be finalized string output or a vector of witnesses whose data has to be fetched when solving the circuit. I then added the logic for printing single values and arrays in the PWG. This logic follows similar logic from acir gen when we can construct a finalized output string.
Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmtwith default settings.Additional context
(If applicable.)