This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
feat(acvm)!: make Backend
trait object safe
#180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #179
Description
Summary of changes
I've spun out
PartialWitnessGenerator::any_missing_assignment
andPartialWitnessGenerator::solve_directives
into standalone functions and added a&self
parameter toPartialWitnessGenerator::solve_black_box_function_call
.Dependency additions / changes
(If applicable.)
Test additions / changes
I've also added a test to ensure that the
Backend
trait remains object safe (I couldn't find any lint, etc. which would enforce this so I've just attempted to pass a trait object to a function as this will fail to compile shouldBackend
not be object safe.Checklist
cargo fmt
with default settings.Additional context
(If applicable.)