Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

fix!: Allow async functions without send on async trait #292

Merged
merged 1 commit into from
May 22, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented May 17, 2023

Related issue(s)

Resolves (link to issue)

Description

Summary of changes

This allows implementors of #[async_trait] to not mark their functions as Send. This is needed because the browser fetch API is async but not Send.

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

@phated phated changed the title fix: Allow async functions without send on async trait fix!: Allow async functions without send on async trait May 22, 2023
@phated phated marked this pull request as ready for review May 22, 2023 16:03
@phated phated requested a review from TomAFrench May 22, 2023 16:03
@phated phated added this pull request to the merge queue May 22, 2023
Merged via the queue into master with commit 9f9fc21 May 22, 2023
@github-actions github-actions bot mentioned this pull request May 22, 2023
@phated phated deleted the phated/no-send branch May 22, 2023 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants