Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssa refactor): Implement array equality in SSA-gen #1704

Merged
merged 2 commits into from
Jun 15, 2023
Merged

fix(ssa refactor): Implement array equality in SSA-gen #1704

merged 2 commits into from
Jun 15, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jun 14, 2023

Description

Problem*

Resolves #1625

Summary*

Implements array equality in ssa-gen. This way we should not need a separate pass in brillig.

We could still improve this code-gen with, e.g. an early exit if any eq returns false but I elected for the more straightforward approach for now since this code is temporary.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher mentioned this pull request Jun 14, 2023
Closed
5 tasks
joss-aztec
joss-aztec suggested changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@joss-aztec joss-aztec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor naming comment

crates/noirc_evaluator/src/ssa_refactor/ssa_gen/context.rs Outdated Show resolved Hide resolved
@joss-aztec joss-aztec mentioned this pull request Jun 15, 2023
Closed
5 tasks
@joss-aztec joss-aztec added this pull request to the merge queue Jun 15, 2023
Merged via the queue into master with commit 0d31d83 Jun 15, 2023
@joss-aztec joss-aztec deleted the jf/array-eq branch June 15, 2023 12:30
This was referenced Jun 15, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joss-aztec joss-aztec joss-aztec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Array equality
2 participants
@jfecher @joss-aztec