New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refine Noir.js API #2732

Merged

kevaundray merged 42 commits into master from kw/more-noir-js

Sep 21, 2023

Contributor

kevaundray commented Sep 16, 2023

Description

Main additions to the API are generateWitness and serialization methods so that the backend will receive a Uint8Array

Problem*

Resolves

Summary*

Documentation

This PR requires documentation updates when merged.
- I will submit a noir-lang/docs PR.
- I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

kevaundray added 19 commits

September 16, 2023 21:09


          add base64 decode method

ea66d2f


          add wip version of input validation

723028f


          add initial witness generation method - does not handle return values

56dc4c1


          add serialize method to abstract away the discrepancies with serializ…

581758f

…ation


          export new methods

752535d


          add mocha, prettier and add type: module for node

e94f00b


          add compiled_examples folder for noir tests

c45fc8f


          do not ignore the target folders

bcbc0ce


          commit .json files for noir_compiled examples

6664b72


          add bb test backend code

8bd188c


          add comment to explain why we are doing type assertions

f431c72


          add some smoke tests

ec3cc28


          add bb.js test to show how it may interact with noir.js

153a72f


          increase timeout

98bfa9f


          add another instance of null function


          update yarn.lock

e479c9c


          Merge remote-tracking branch 'origin/master' into kw/more-noir-js

c7d48fd


          add yarn test

4cdeeae


          remove .only

dd6b837

socket-security bot commented Sep 16, 2023 •

edited

Loading

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
eslint-plugin-prettier	4.2.1...5.0.0	None	`+27/-1`	568 kB	jounqin

🚮 Removed packages: @noir-lang/[email protected], [email protected]

kevaundray commented

View reviewed changes

tooling/noir_js/src/input_validation.ts Outdated Show resolved Hide resolved

kevaundray commented

View reviewed changes

tooling/noir_js/src/serialize.ts Show resolved Hide resolved

kevaundray commented

View reviewed changes

tooling/noir_js/test/backend/barretenberg.ts Show resolved Hide resolved

kevaundray commented

View reviewed changes

tooling/noir_js/test/backend/barretenberg.ts Show resolved Hide resolved


          no test is using 1_mul so we can remove it

de1f7ef

kevaundray commented

View reviewed changes

tooling/noir_js/test/backend/barretenberg.ts Show resolved Hide resolved

kevaundray added 2 commits

September 16, 2023 22:19


          add separate inner proof -- this quickly verifies that inner proof cr…

1fb56d0

…eation is not broken


          add bug-doc test that creates and verifies an inner and outer proof u…

3666b5a

…sing two _different_ instances.

kevaundray commented

View reviewed changes

tooling/noir_js/src/input_validation.ts Outdated Show resolved Hide resolved


          Merge remote-tracking branch 'origin/master' into kw/more-noir-js

23f9bfa

kevaundray added 5 commits

September 18, 2023 10:40


          explicit any

edcb749


          hack around linting -> I think any should be explicit

ed6369c


          cannot remove ts-ignore unfortunately, or it will not compile

ae9a6fa


          update dependencies

be7e09b


          linter

403d9b5

kevaundray marked this pull request as ready for review

September 18, 2023 21:59

Collaborator

Savio-Sou commented Sep 19, 2023

Should this be documented as a part of / after noir-lang/docs#371?

kevaundray requested a review from TomAFrench

September 19, 2023 13:27

TomAFrench added 2 commits

September 19, 2023 14:00


          Merge branch 'master' into kw/more-noir-js

460a8a9


          chore: update integration test glob

75c226d

kevaundray requested a review from vezenovm

September 20, 2023 15:23

TomAFrench previously approved these changes

View reviewed changes

vezenovm previously approved these changes

View reviewed changes

tooling/noir_js/src/input_validation.ts Show resolved Hide resolved

tooling/noir_js/src/serialize.ts Show resolved Hide resolved

tooling/noir_js/test/backend/barretenberg.ts Show resolved Hide resolved

tooling/noir_js/test/backend/barretenberg.ts Show resolved Hide resolved

tooling/noir_js/test/backend/barretenberg.ts Show resolved Hide resolved

tooling/noir_js/test/node/e2e.test.ts Show resolved Hide resolved


          Merge branch 'master' into kw/more-noir-js

7af1dc6

kevaundray dismissed stale reviews from vezenovm and TomAFrench via

7af1dc6

September 20, 2023 23:46

kevaundray added 3 commits

September 21, 2023 00:11


          fix package.json

f8ad376


          Merge remote-tracking branch 'origin/master' into kw/more-noir-js

0a52241


          cargo fmt

6d5d960

kevaundray requested review from TomAFrench and vezenovm

September 21, 2023 11:31

kevaundray mentioned this pull request

Discrepancy in serialization between acvm_js and backends in Noir.js #2771

Closed

kevaundray enabled auto-merge

September 21, 2023 11:50

kevaundray added this pull request to the merge queue

TomAFrench approved these changes

View reviewed changes

Merged via the queue into master with commit e79f1ed

17 checks passed

kevaundray deleted the kw/more-noir-js branch

September 21, 2023 12:03

kevaundray mentioned this pull request

chore(noir): Release 0.13.0 #2734

Merged

TomAFrench mentioned this pull request

chore: standardize witness map serialization format in JS #3104

Merged

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet