Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle warnings in SSA #3131

Closed
guipublic opened this issue Oct 12, 2023 · 0 comments · Fixed by #3205
Closed

Handle warnings in SSA #3131

guipublic opened this issue Oct 12, 2023 · 0 comments · Fixed by #3205
Assignees
Labels
enhancement New feature or request

Comments

@guipublic
Copy link
Contributor

Problem

SSA codegen/acirgen can generate errors, for instance it can detect index out-of-bounds, failing constraint, division by zero,..
The error is then properly reported to the user.
However, it cannot returns a warning instead of an error, because errors and warnings are handled but rust Result<> paradigm, which enforces the code to either return a correct value, or to stop with the error.

Happy Case

When we want to only warn the user, we must be able to return both the correct result, as well as the generated warnings.

Alternatives Considered

No response

Additional Context

The PR #2978 is de-activated by PR #3128 until we can return a warning instead of an error.

Would you like to submit a PR for this Issue?

No

Support Needs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant