Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disable return constant error #3128

Merged
merged 6 commits into from
Oct 14, 2023
Merged

Conversation

kevaundray
Copy link
Contributor

Description

Currently this breaks contracts in aztec and the private kernel circuit. Although its likely a logic problem in those circuits, since we don't generate enough information to actually debug them right now (just the line) -- Its better to disable it until it becomes a warning and then work on improving the diagnostic so that users can figure out why there is a constant being returned as a public input.

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray
Copy link
Contributor Author

@guipublic tagging you, feel free to tag the issue when you create it about making this into a warning

@guipublic
Copy link
Contributor

you also need to de-activate the test case

@kevaundray kevaundray marked this pull request as ready for review October 13, 2023 22:14
@kevaundray kevaundray added this pull request to the merge queue Oct 14, 2023
Merged via the queue into master with commit 37315f8 Oct 14, 2023
27 checks passed
@kevaundray kevaundray deleted the kw/disable-return-error branch October 14, 2023 00:50
Sakapoi pushed a commit to Sakapoi/noir_fork that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants