Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow performance on bigger workspace with goto-definitions #3915

Closed
jbremmer opened this issue Dec 22, 2023 · 0 comments
Closed

Slow performance on bigger workspace with goto-definitions #3915

jbremmer opened this issue Dec 22, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@jbremmer
Copy link

Aim

While performing goto definition on bigger workspace, eg. noir-protocol-circuits it takes long time to execute (~15s).

Expected Behavior

Time to execute request to be faster.

Bug

All workspaces are considered for operation while only single package for which the currently open file belongs to needs to be considered.

To Reproduce

Installation Method

None

Nargo Version

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response

@jbremmer jbremmer added the bug Something isn't working label Dec 22, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 22, 2023
# Description

## Problem\*

Resolves 

Slow performance on bigger workspace with goto-definitions #3915

## Summary\*

Optimises performance of a request from ~16 seconds to ~1s on sample
workspace
[noir-protocol-circuits](https://github.com/AztecProtocol/aztec-packages/tree/master/yarn-project/noir-protocol-circuits)

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants