Compiler should not panic when an oracle is called from constrained method

[LogvinovLeon]

Aim

Get compilation error instead of compiler panic

Expected Behavior

compilation error

Bug

The application panicked (crashed).
Message: internal error: entered unreachable code: All oracle methods should be wrapped in an unconstrained fn
Location: compiler/noirc_evaluator/src/ssa/acir_gen/mod.rs:615

To Reproduce

1. Call an oracle function directly from constrained code

Project Impact

None

Impact Context

No response

Workaround

Yes

Workaround Description

Just don't do it ;)

Additional Context

No response

Installation Method

None

Nargo Version

noirc version = 0.25.0+3ad88696ab63d8b1838b4ca7e9a3a97f823ca976

NoirJS Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

[TomAFrench]

Thanks for highlighting this!

This can be done with similar logic used to prevent passing slices to unconstrained functions from constrained ones.

noir/compiler/noirc_frontend/src/hir/type_check/expr.rs

Lines 186 to 195 in a8b7cdb

	// Check that we are not passing a slice from an unconstrained runtime to a constrained runtime
	if is_current_func_constrained
	&& is_unconstrained_call
	&& return_type.contains_slice()
	{
	self.errors.push(TypeCheckError::UnconstrainedSliceReturnToConstrained {
	span: self.interner.expr_span(expr_id),
	});
	return Type::Error;
	}

[jfecher]

@TomAFrench we should probably generalize that check to error for all types that are invalid to pass from unconstrained to constrained. Such as references.