LSP: show parameter name inlay hints #5554
Labels
enhancement
New feature or request
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 19, 2024
# Description ## Problem Resolves #5554 ## Summary The type and parameter hints can be toggled from a configuration which we get during LSP initialization. However, vscode-noir doesn't sent those configs yet, but at least the code here will work once we do that on the other side. For now they will always show up. https://github.com/user-attachments/assets/ebc52b52-287a-43fa-b87d-1a74012c3e78 ## Additional Context None. ## Documentation Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Given that Noir, like Rust, doesn't have named arguments, when one has a function with multiple arguments it's hard to tell which argument is which parameter. Rust Analyzer shows inlay hints for them, but only when the name of the argument doesn't "match" the name of the parameter:
Here
two:is shown, but notone:because it's obvious the first argument is "one".It would be nice if Noir LSP provided the same thing.
Happy Case
LSP returns inlay hints for parameter names.
Project Impact
None
Impact Context
No response
Workaround
None
Workaround Description
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
Yes
Support Needs
No response
The text was updated successfully, but these errors were encountered: