Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing a unconstrained fn to an argument that expects fn errors #5763

Closed
asterite opened this issue Aug 19, 2024 · 0 comments · Fixed by #5764
Closed

Passing a unconstrained fn to an argument that expects fn errors #5763

asterite opened this issue Aug 19, 2024 · 0 comments · Fixed by #5764
Assignees
Labels
bug Something isn't working

Comments

@asterite
Copy link
Collaborator

Aim

Passing a unconstrained fn to an argument that expects fn shouldn't be allowed, but currently it errors instead of giving a warning.

Expected Behavior

This code:

fn main() {
    foo(baz);
}

fn foo(f: fn(i32) -> i32) -> i32 {
    f(1)
}

unconstrained fn baz(x: i32) -> i32 {
    x + 1
}

gives a warning, not an error.

Bug

The code gives an error.

To Reproduce

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@asterite asterite added the bug Something isn't working label Aug 19, 2024
@asterite asterite self-assigned this Aug 19, 2024
TomAFrench pushed a commit that referenced this issue Aug 20, 2024
# Description

## Problem

Resolves #5763

## Summary

This code is handled differently than the other `unsafe` checks, and I
forgot about that.

## Additional Context

This issue is preventing noir syncs on Aztec Packages.

## Documentation

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant