feat(nargo): add flag to verify created proofs #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
checked-prove
branch
2 times, most recently
from
8ecfda2
to
bb48024
Compare
TomAFrench
force-pushed
the
checked-prove
branch
from
bb48024
to
e73cb3f
Compare
TomAFrench
force-pushed
the
checked-prove
branch
from
e73cb3f
to
21572d0
Compare
jfecher
reviewed
Feb 6, 2023
|
Looks good, I'll approve once merge conflicts are fixed |
* master: (28 commits) chore(ci): Add release token to enable runs against release PR (#840) feat(ssa): array sort (#754) chore: update readme (#811) chore: fix clippy (#825) chore: remove stale comment on HirFunction.unchecked_from_expr (#827) chore: Getter naming refactor (#803) chore: updated "HirFunction::unsafe_from_expr" to "HirFunction::unchecked_from_expr" (#823) chore: Forbid unsafe code (#824) chore: Follow rust naming convention (#801) feat(ci): Add concurrency group for rust workflow (#806) chore(ssa): rename impl method to follow Rust guideline (#782) fix(nargo): `nargo test` now only runs test functions defined in the current module (#805) chore(nargo): Remove outdated error message when Prover/Verifier.toml is missing (#807) chore(ssa): rename codegen to ssa_gen + reorg of `Value` struct (#797) chore(nargo): abstract paths from nargo's working directory (#761) chore(ci): Rename workflows (#804) feat: Impls with generics (#798) chore(ssa): Add doc comments on `Opcode` struct (#778) fix: operators issuing type errors when used with matching integer types arising from generic code (#789) chore(nargo)!: bump MSRV to 1.66.0 (#799) ...
kevaundray
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #719
Description
Draft while waiting for #725 to be merged
Summary of changes
This PR adds a
--checkedflag tonargo provewhich immediately verifies the proof after generation. Most of the changes in this PR are to change to have I/O being done explicitly rather than implicitly throughexecute_programto avoid having to write to/read from the toml files unnecessarily.Dependency additions / changes
N/A
Test additions / changes
Integration tests now make use of this flag rather than calling
verify_with_path.Checklist
cargo fmtwith default settings.Additional context