Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(nargo): Remove outdated error message when Prover/Verifier.toml is missing #807

Merged
merged 2 commits into from
Feb 11, 2023
Merged

chore(nargo): Remove outdated error message when Prover/Verifier.toml is missing #807

merged 2 commits into from
Feb 11, 2023

Conversation

kevaundray
Copy link
Contributor

Related issue(s)

Resolves #800

Description

Error message now says:

 Error: cannot find Prover.toml file.
 Expected location: "crates/nargo/tests/test_data/1_mul/Prover.toml" 
 Please generate this file at the expected location.

Summary of changes

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

@kevaundray kevaundray changed the title Remove outdated error message when Prover/Verifier.toml is missing chore: Remove outdated error message when Prover/Verifier.toml is missing Feb 11, 2023
@kevaundray kevaundray changed the title chore: Remove outdated error message when Prover/Verifier.toml is missing chore(nargo): Remove outdated error message when Prover/Verifier.toml is missing Feb 11, 2023
@kevaundray kevaundray added this pull request to the merge queue Feb 11, 2023
Merged via the queue into master with commit 4dbb278 Feb 11, 2023
@kevaundray kevaundray deleted the kw/fix-prover-toml-error branch February 11, 2023 19:11
TomAFrench added a commit that referenced this pull request Feb 14, 2023
@TomAFrench
Merge branch 'master' into checked-prove
9faec51 
* master: (28 commits)
  chore(ci): Add release token to enable runs against release PR (#840)
  feat(ssa): array sort (#754)
  chore: update readme (#811)
  chore: fix clippy (#825)
  chore: remove stale comment on HirFunction.unchecked_from_expr (#827)
  chore: Getter naming refactor (#803)
  chore: updated "HirFunction::unsafe_from_expr" to "HirFunction::unchecked_from_expr" (#823)
  chore: Forbid unsafe code (#824)
  chore: Follow rust naming convention (#801)
  feat(ci): Add concurrency group for rust workflow (#806)
  chore(ssa): rename impl method to follow Rust guideline (#782)
  fix(nargo): `nargo test` now only runs test functions defined in the current module (#805)
  chore(nargo): Remove outdated error message when Prover/Verifier.toml is missing (#807)
  chore(ssa): rename codegen to ssa_gen + reorg of `Value` struct (#797)
  chore(nargo): abstract paths from nargo's working directory (#761)
  chore(ci): Rename workflows (#804)
  feat: Impls with generics (#798)
  chore(ssa): Add doc comments on `Opcode` struct (#778)
  fix: operators issuing type errors when used with matching integer types arising from generic code (#789)
  chore(nargo)!: bump MSRV to 1.66.0 (#799)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misleading error when Prover.toml is missing
2 participants
@kevaundray @jfecher