chore(ssa refactor): Add loop unrolling pass #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
commented
May 17, 2023
jfecher
commented
May 17, 2023
jfecher
commented
May 17, 2023
kevaundray
reviewed
May 18, 2023
kevaundray
reviewed
May 18, 2023
kevaundray
reviewed
May 18, 2023
kevaundray
reviewed
May 18, 2023
kevaundray
reviewed
May 18, 2023
kevaundray
reviewed
May 18, 2023
kevaundray
reviewed
May 18, 2023
kevaundray
reviewed
May 18, 2023
joss-aztec
suggested changes
May 22, 2023
joss-aztec
approved these changes
May 24, 2023
TomAFrench
added a commit
that referenced
this pull request
May 24, 2023
* master: chore(ssa refactor): Add loop unrolling pass (#1364) chore: Add terms added in ssa refactor to `cspell` (#1385) chore(ssa refactor): Optimize constant `jmpif`s into `jmp`s (#1374) feat: Allow warnings by default (#1383) chore(github): Update GitHub Pull Request Template (#1370) chore(github): Update GitHub Bug Report Template (#1368) chore(ssa refactor): Update mem2reg pass to work with multiple functions and blocks (#1375) chore(ssa refactor): Add pass to simplify the control flow graph (#1373) chore(github): Update GitHub Feature Request Template (#1369)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #(none)
Description
Summary of changes
Adds a loop unrolling pass to the ssa refactoring.
This pass currently does expect all loops to have constant indices and be unroll-able, so it will fail if it encounters a non-constant loop. As a result, this pass should currently take place only after function inlining when any comptime parameters used as loop indices become known. This limitation is not inherent to the pass however, we just need to modifyThis limitation is no longer the case - I've updated the PR. Loops using non-constant indices now are left unmodified which allows us some more flexibility in ssa pass ordering.find_next_loopto return all loops instead of one (only 1 line needs to change for this), add bookkeeping to remember which loops failed to inline, and refresh the list of loops when unrolling one loop modifies the blocks in another (this happens with nested loops).Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context