Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(brillig): implemented blackbox functions #1788

Merged
merged 4 commits into from
Jul 7, 2023
Merged

feat(brillig): implemented blackbox functions #1788

merged 4 commits into from
Jul 7, 2023

Conversation

sirasistant
Copy link
Contributor

@sirasistant sirasistant commented Jun 22, 2023 •
edited
Loading

Description

Problem*

Implements the first blackbox functions compilation to brillig.

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@sirasistant sirasistant mentioned this pull request Jun 22, 2023
Merged
2 tasks
@sirasistant sirasistant marked this pull request as ready for review July 7, 2023 07:03
@sirasistant sirasistant requested review from kevaundray and ludamad and removed request for kevaundray July 7, 2023 07:03
@sirasistant sirasistant changed the title feat(brillig): implemented blackbox functions [DO NOT MERGE] feat(brillig): implemented blackbox functions Jul 7, 2023
ludamad
ludamad approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevaundray kevaundray added this pull request to the merge queue Jul 7, 2023
Merged via the queue into master with commit f9f38de Jul 7, 2023
13 checks passed
@kevaundray kevaundray deleted the brillig/first_blackbox branch July 7, 2023 11:04
@kevaundray kevaundray mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludamad ludamad ludamad approved these changes

@kevaundray kevaundray Awaiting requested review from kevaundray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirasistant @ludamad @kevaundray