Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix auto-deref operations assigning the wrong result type #1904

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jul 10, 2023

Description

Problem*

Resolves #1899

Summary*

When we encounter foo.bar where foo is a reference, we automatically dereference foo, transforming the code into (*foo).bar. When this happens, we previously accidentally set the type of foo to T and *foo to &mut T instead of the reverse. I've switched the two cases.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher requested a review from sirasistant July 10, 2023 15:57
@kevaundray kevaundray added this pull request to the merge queue Jul 10, 2023
Merged via the queue into master with commit 827f78c Jul 10, 2023
5 checks passed
@kevaundray kevaundray deleted the jf/fix-1899 branch July 10, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSA with binary operation with operands of type reference
2 participants