Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Update to ACVM 0.18.1 and implement missing brillig blackboxes #1914

Merged
merged 7 commits into from
Jul 12, 2023
Merged

feat!: Update to ACVM 0.18.1 and implement missing brillig blackboxes #1914

merged 7 commits into from
Jul 12, 2023

Conversation

sirasistant
Copy link
Contributor

@sirasistant sirasistant commented Jul 12, 2023 •
edited
Loading

Description

Problem*

Summary*

Updates to ACVM 0.18.1 and implements the missing blackbox functions in brillig.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@sirasistant sirasistant changed the title feat: update to latest ACVM and implement missing brillig blackboxes [DO NOT MERGE] feat: Update to latest ACVM and implement missing brillig blackboxes [DO NOT MERGE] Jul 12, 2023
@sirasistant sirasistant marked this pull request as ready for review July 12, 2023 16:20
@sirasistant sirasistant changed the title feat: Update to latest ACVM and implement missing brillig blackboxes [DO NOT MERGE] feat: Update to latest ACVM and implement missing brillig blackboxes Jul 12, 2023
vezenovm
vezenovm previously approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@vezenovm vezenovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one tiny nit

crates/noirc_evaluator/src/brillig/brillig_gen/brillig_black_box.rs Outdated Show resolved Hide resolved
@kevaundray kevaundray added this pull request to the merge queue Jul 12, 2023
@kevaundray kevaundray removed this pull request from the merge queue due to a manual request Jul 12, 2023
@kevaundray kevaundray changed the title feat: Update to latest ACVM and implement missing brillig blackboxes feat!: Update to ACVM 0.18.1 and implement missing brillig blackboxes Jul 12, 2023
@kevaundray kevaundray added this pull request to the merge queue Jul 12, 2023
Merged via the queue into master with commit 2bc7d25 Jul 12, 2023
6 checks passed
@kevaundray kevaundray deleted the arv/brillig_blackbox branch July 12, 2023 19:30
@kevaundray kevaundray mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vezenovm vezenovm vezenovm approved these changes

@kevaundray kevaundray Awaiting requested review from kevaundray

@guipublic guipublic Awaiting requested review from guipublic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirasistant @vezenovm @kevaundray