Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Format strings for prints #1952

Merged
merged 67 commits into from
Aug 1, 2023
Merged

feat: Format strings for prints #1952

merged 67 commits into from
Aug 1, 2023

Commits on Jul 11, 2023

  1. initial stdlib methods to start refactoring logign

    @vezenovm
    vezenovm committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    730c9ff View commit details
    Browse the repository at this point in the history

  2. foreign call enum

    @vezenovm
    vezenovm committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    d75aedb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into mv/brillig_logs

    @vezenovm
    vezenovm committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    f28b915 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. working println and println_format w/ brillig oracles

    @vezenovm
    vezenovm committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    ce082b6 View commit details
    Browse the repository at this point in the history

  2. merge conflicts w/ master

    @vezenovm
    vezenovm committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    4501b69 View commit details
    Browse the repository at this point in the history

  3. fix up brillig_oracle test

    @vezenovm
    vezenovm committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    44ef833 View commit details
    Browse the repository at this point in the history

  4. uncomment regression test for slice return from foreign calls in brillig

    @vezenovm
    vezenovm committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    e9f6488 View commit details
    Browse the repository at this point in the history

  5. cargo clippy

    @vezenovm
    vezenovm committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    e457faf View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. got structs serialized correctly without aos_to_soa

    @vezenovm
    vezenovm committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    7cb1b10 View commit details
    Browse the repository at this point in the history

  2. remove dbg

    @vezenovm
    vezenovm committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    c7e4f0a View commit details
    Browse the repository at this point in the history

  3. working println_format

    @vezenovm
    vezenovm committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    1c64aff View commit details
    Browse the repository at this point in the history

  4. merge conflicts w/ master

    @vezenovm
    vezenovm committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    e3d8931 View commit details
    Browse the repository at this point in the history

  5. cargo clippy

    @vezenovm
    vezenovm committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    5c24bf7 View commit details
    Browse the repository at this point in the history

  6. rename enable_slices to experimental_ssa

    @vezenovm
    vezenovm committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    f4b17d4 View commit details
    Browse the repository at this point in the history

  7. remove dbg and fix format_field_string

    @vezenovm
    vezenovm committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    d2065ea View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. initial work towards FmtStr literal

    @vezenovm
    vezenovm committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    b1739c0 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. working format strins with one unified println method, still have som… 

    …e cleanup to-do, use Display/Debug for pretty printing
    @vezenovm
    vezenovm committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    613c94b View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. remove old comment

    @vezenovm
    vezenovm committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    2d459a7 View commit details
    Browse the repository at this point in the history

  2. moved resolution of string to fmt string only when passing literals t… 

    …o functions
    @vezenovm
    vezenovm committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    8b5c523 View commit details
    Browse the repository at this point in the history

  3. delete temp intrinsic for println new

    @vezenovm
    vezenovm committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    fd59219 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary subtype

    @vezenovm
    vezenovm committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    9a7519b View commit details
    Browse the repository at this point in the history

  5. remove debugging code w/ def id as part of mono pass Ident

    @vezenovm
    vezenovm committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    ff1d406 View commit details
    Browse the repository at this point in the history

  6. cleanup formatting stuff

    @vezenovm
    vezenovm committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    4a2c098 View commit details
    Browse the repository at this point in the history

  7. master conflicts

    @vezenovm
    vezenovm committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    3623283 View commit details
    Browse the repository at this point in the history

  8. merge conflcits w/ mv/brillig_logs after master merge

    @vezenovm
    vezenovm committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    5b27b77 View commit details
    Browse the repository at this point in the history

  9. cargo clippy

    @vezenovm
    vezenovm committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    ff34dd0 View commit details
    Browse the repository at this point in the history

  10. resolver test for fmt string

    @vezenovm
    vezenovm committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    2288149 View commit details
    Browse the repository at this point in the history

  11. remove TODO comment

    @vezenovm
    vezenovm committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    a0df28c View commit details
    Browse the repository at this point in the history

  12. cargo clippy

    @vezenovm
    vezenovm committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    6c70d1f View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. pr comments

    @vezenovm
    vezenovm committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    5e6d0d5 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. merge conflicts w/ master after brillig println merge

    @vezenovm
    vezenovm committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    77c771c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mv/format-string

    @vezenovm
    vezenovm committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    2ebd23a View commit details
    Browse the repository at this point in the history

  3. expose full fmtstr type to the user

    @vezenovm
    vezenovm committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    f19b1d4 View commit details
    Browse the repository at this point in the history

  4. add back fmt string resolver test

    @vezenovm
    vezenovm committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    4615225 View commit details
    Browse the repository at this point in the history

  5. don't allow comparison of format strings

    @vezenovm
    vezenovm committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    0adca79 View commit details
    Browse the repository at this point in the history

  6. use JsonType Display trait

    @vezenovm
    vezenovm committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    0572d74 View commit details
    Browse the repository at this point in the history

  7. add issue for printing func params

    @vezenovm
    vezenovm committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    bba1ed0 View commit details
    Browse the repository at this point in the history

  8. remove Token::F variant

    @vezenovm
    vezenovm committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    1cd2881 View commit details
    Browse the repository at this point in the history

  9. remove old append_abi_arg func

    @vezenovm
    vezenovm committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    f953f29 View commit details
    Browse the repository at this point in the history

  10. add comments to append_abi-arg

    @vezenovm
    vezenovm committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    46240be View commit details
    Browse the repository at this point in the history

  11. fix: format printing function parameters, store exprs rather than ide… 

    …nts as part of HirLiteral::FmtStr
    @vezenovm
    vezenovm committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    692f85e View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. remove ve old comment about not being able to use witness values in f… 

    …mt strings
    @vezenovm
    vezenovm committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    741ef8b View commit details
    Browse the repository at this point in the history

  2. push fix for asfs{x}{x} case and more specific regex for idents

    @vezenovm
    vezenovm committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    009279e View commit details
    Browse the repository at this point in the history

  3. Update crates/noirc_evaluator/src/ssa_refactor/ssa_gen/mod.rs 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    643fca5 View commit details
    Browse the repository at this point in the history

  4. remove is_match check

    @vezenovm
    vezenovm committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    fa35f1b View commit details
    Browse the repository at this point in the history

  5. breakout literal fmt str case in resolver to its own func

    @vezenovm
    vezenovm committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    c783a3b View commit details
    Browse the repository at this point in the history

  6. update resolve_fmt_strings test

    @vezenovm
    vezenovm committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    515ef1e View commit details
    Browse the repository at this point in the history

  7. switch to_owned placement in resolve_fmt_str_literal

    @vezenovm
    vezenovm committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    a701fb8 View commit details
    Browse the repository at this point in the history

  8. Update crates/noirc_frontend/src/ast/mod.rs 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    3dc2c83 View commit details
    Browse the repository at this point in the history

  9. fix find_numeric_generics_in_type

    @vezenovm
    vezenovm committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    a7fa482 View commit details
    Browse the repository at this point in the history

  10. add case of fmt string in if statement

    @vezenovm
    vezenovm committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    9971fac View commit details
    Browse the repository at this point in the history

  11. add contains_numeric_typevar cases for string and fmtstring

    @vezenovm
    vezenovm committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    a97f251 View commit details
    Browse the repository at this point in the history

  12. add unify and subtype checks and fix resolver fmt string test

    @vezenovm
    vezenovm committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    927abfe View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. merge conflicts w/ master and cargo fmt

    @vezenovm
    vezenovm committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    b30c543 View commit details
    Browse the repository at this point in the history

  2. working generic fmtstr types

    @vezenovm
    vezenovm committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    5c2fddd View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. separate fmtstr codegen into variables

    @vezenovm
    vezenovm committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    02ed2b8 View commit details
    Browse the repository at this point in the history

  2. Update crates/noirc_frontend/src/parser/parser.rs

    @jfecher
    jfecher authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    0556ca3 View commit details
    Browse the repository at this point in the history

  3. Update crates/noirc_abi/src/input_parser/json.rs 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    9c84e21 View commit details
    Browse the repository at this point in the history

  4. Update crates/noirc_frontend/src/ast/mod.rs 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    9d320f7 View commit details
    Browse the repository at this point in the history

  5. Update crates/noirc_frontend/src/monomorphization/mod.rs 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    8a5825f View commit details
    Browse the repository at this point in the history

  6. Update crates/noirc_frontend/src/monomorphization/mod.rs 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    618d376 View commit details
    Browse the repository at this point in the history

  7. Update crates/noirc_frontend/src/monomorphization/mod.rs 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    a940145 View commit details
    Browse the repository at this point in the history

  8. Update crates/noirc_frontend/src/parser/parser.rs 

    Co-authored-by: jfecher <[email protected]>
    @vezenovm @jfecher
    vezenovm and jfecher authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    34f1d58 View commit details
    Browse the repository at this point in the history

  9. keep the size of fmtrstr type as mandatory

    @vezenovm
    vezenovm committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    4f9bac7 View commit details
    Browse the repository at this point in the history

  10. print original fmt string in monomorphization printer

    @vezenovm
    vezenovm committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c2e6ef7 View commit details
    Browse the repository at this point in the history

  11. print literal update for fmtstr

    @vezenovm
    vezenovm committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    5819d10 View commit details
    Browse the repository at this point in the history

  12. add parens to f-string literal printer

    @vezenovm
    vezenovm committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    9c95414 View commit details
    Browse the repository at this point in the history