fix: Slice initialization #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
* Start experiment to merge array and slice types * Finish merger of slices and arrays * Implement missing try_bind function * Add missed case for NotConstant * Fix some tests * Fix poseidon test * Fix evaluation of slice length * Fix tests * fix: Slice initialization (#2080) * fix: Initialize Value::Array of type Slice * test: improved brillig test after bug fix * Add array -> slice coercion * Update comment * Clippy suggestion * Use coercions in more places to match rust --------- Co-authored-by: Álvaro Rodríguez <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…2084) * Start experiment to merge array and slice types * Finish merger of slices and arrays * Implement missing try_bind function * Add missed case for NotConstant * Fix some tests * Fix poseidon test * Fix evaluation of slice length * Fix tests * fix: Initialize Value::Array of type Slice * test: improved brillig test after bug fix * fix: Slice initialization (#2080) * fix: Initialize Value::Array of type Slice * test: improved brillig test after bug fix * feat: nested slices * fix: insert and remove indexes * fix: add missing deallocation * test: added more cases to nested slice test * refactor: simplify array length instructions * test: fix stale import * refactor: reuse element_size and regen json * Update crates/noirc_evaluator/src/brillig/brillig_gen/brillig_block.rs --------- Co-authored-by: Jake Fecher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
After @jfecher PR #2070 now Value::Array can have Type::Slice. This PR tries to handle it appropiately.
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.