Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Basic implementation of traits #2368

Merged
merged 31 commits into from
Aug 30, 2023
Merged

feat: Basic implementation of traits #2368

merged 31 commits into from
Aug 30, 2023

Commits on Aug 29, 2023

  1. Maybe it's better this way

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    49984f7 View commit details
    Browse the repository at this point in the history

  2. Collect traits from AST to def_map

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    4a007aa View commit details
    Browse the repository at this point in the history

  3. Collect trait implementations in def collector

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    29094f0 View commit details
    Browse the repository at this point in the history

  4. Resolve traits

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    5d00169 View commit details
    Browse the repository at this point in the history

  5. Separate collected trait implementations

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    a6615f2 View commit details
    Browse the repository at this point in the history

  6. fix(testsuite): converted traits tests to proper nargo packages 

    Converted the traits-related tests that are supposed to fail, to the proper
format (nargo packages) in the crates/nargo_cli/tests/compile_failure directory.
This ensures that the tests are now executed when 'cargo test' is run.
    @nickysn @ymadzhunkov
    nickysn authored and ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    568119f View commit details
    Browse the repository at this point in the history

  7. fix(testsuite): added Prover.toml files to the traits compile_failure… 

    … tests
    @nickysn @ymadzhunkov
    nickysn authored and ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    788ef07 View commit details
    Browse the repository at this point in the history

  8. fix(testsuite): Move trait test into correct place so it can run auto… 

    …matically
    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    5032e7d View commit details
    Browse the repository at this point in the history

  9. Rename trait_not_exists -> trait_not_in_scope

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    ed1790a View commit details
    Browse the repository at this point in the history

  10. Resolve some of PR comments

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    1c63592 View commit details
    Browse the repository at this point in the history

  11. better naming as requsted in PR

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    4f5d1df View commit details
    Browse the repository at this point in the history

  12. Remove empty else and rename noir_function -> impl_method

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    a7f7188 View commit details
    Browse the repository at this point in the history

  13. Check for matching of trait implementation method, when unspecified r… 

    …eturn type
    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    e46c437 View commit details
    Browse the repository at this point in the history

  14. Apply cargo clippy suggestions

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    44d9ee4 View commit details
    Browse the repository at this point in the history

  15. Delete duplicated test

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    b41bab5 View commit details
    Browse the repository at this point in the history

  16. Partial trait resolution

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    7046cf1 View commit details
    Browse the repository at this point in the history

  17. Extract comparison of return type into stuct assosiated method

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    3f98928 View commit details
    Browse the repository at this point in the history

  18. Add test of a trait with default implemetation that is used

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    68f0a15 View commit details
    Browse the repository at this point in the history

  19. Allow usage of default trait implementation

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    d5caec4 View commit details
    Browse the repository at this point in the history

  20. RP remark: fix typo

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    295f057 View commit details
    Browse the repository at this point in the history

  21. Maybem it's better this way

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    36096d4 View commit details
    Browse the repository at this point in the history

  22. Fix clippy warnings

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    87ed6e2 View commit details
    Browse the repository at this point in the history

  23. Add test of override ot Trait default method

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    28edd77 View commit details
    Browse the repository at this point in the history

  24. Try to fix 'nix flake check -L'

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    d2873ef View commit details
    Browse the repository at this point in the history

  25. Try to fix CI dependency failed build

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    dd88b96 View commit details
    Browse the repository at this point in the history

  26. An other try

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    961550b View commit details
    Browse the repository at this point in the history

  27. Update crates/noirc_frontend/src/ast/mod.rs 

    convert to `from_func_return_type` to struct method. Definitely a better approach.

Co-authored-by: jfecher <[email protected]>
    @yordanmadzhunkov @jfecher @ymadzhunkov
    2 people authored and ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    bbe62b6 View commit details
    Browse the repository at this point in the history

  28. Update crates/noirc_frontend/src/hir/def_collector/dc_crate.rs 

    clean up

Co-authored-by: jfecher <[email protected]>
    @yordanmadzhunkov @jfecher @ymadzhunkov
    2 people authored and ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    28a3aaa View commit details
    Browse the repository at this point in the history

  29. Build fix and cargo fmt

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    2ef48e2 View commit details
    Browse the repository at this point in the history

  30. Fix build after rebase of master

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    05b5208 View commit details
    Browse the repository at this point in the history

  31. Fix trait tests

    @ymadzhunkov
    ymadzhunkov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    43ec02d View commit details
    Browse the repository at this point in the history