Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nargo): Support optional directory in git dependencies #2436

Merged
merged 3 commits into from
Aug 25, 2023
Merged

feat(nargo): Support optional directory in git dependencies #2436

merged 3 commits into from
Aug 25, 2023

Conversation

sirasistant
Copy link
Contributor

Description

Problem*

Resolves #2102

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@sirasistant sirasistant marked this pull request as ready for review August 25, 2023 11:47
@github-actions github-actions bot mentioned this pull request Aug 25, 2023
Closed
@sirasistant sirasistant changed the title feat(nargo): Add support for optional directory feat(nargo): Add support for optional directory in git dependencies Aug 25, 2023
@sirasistant sirasistant mentioned this pull request Aug 25, 2023
Closed
@phated phated changed the title feat(nargo): Add support for optional directory in git dependencies feat(nargo): Support optional directory in git dependencies Aug 25, 2023
phated
phated approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks @sirasistant ❤️

@sirasistant sirasistant added this pull request to the merge queue Aug 25, 2023
Merged via the queue into master with commit 84fdc55 Aug 25, 2023
18 checks passed
@sirasistant sirasistant deleted the arv/subpath_git_dep branch August 25, 2023 16:54
@kevaundray kevaundray mentioned this pull request Aug 25, 2023
Merged
TomAFrench added a commit that referenced this pull request Aug 25, 2023
@TomAFrench
Merge branch 'master' into assert-eq-builtin
6a5a3d3 
* master:
  fix: Implement new mem2reg pass (#2420)
  feat(nargo): Support optional directory in git dependencies (#2436)
  fix(acir_gen): Pass accurate contents to slice inputs for bb func calls (#2435)
  fix(ssa): codegen missing check for unary minus (#2413)
  fix(lsp): Remove duplicated creation of lenses (#2433)
  feat: Add `test(should_fail)` attribute for tests that are meant to fail (#2418)
  chore: improve error message for InternalError (#2429)
  chore: Add stdlib to every crate as it is added to graph (#2392)
@phated phated mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@kevaundray kevaundray Awaiting requested review from kevaundray

@vezenovm vezenovm Awaiting requested review from vezenovm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import a git dependency by specifying a url and filepath _not_ at the repo's root.
2 participants
@sirasistant @phated