Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix barretenberg noir typescript wrapper #2922

Merged
merged 49 commits into from
Oct 2, 2023

Conversation

kevaundray
Copy link
Contributor

Description

This PR fixes two issues:

  • default export was not last in the list, so next.js would not compile
  • I was getting an error saying could find serialize.js, which sort of makes sense because it got renamed to serialize.cjs. Maybe there is a way around this, I know just supplying the extra package.json files in each built artifact works, so I went with that

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray changed the base branch from master to kw/compile-noir-types-package October 1, 2023 13:40
@kevaundray
Copy link
Contributor Author

Relint on #2921

@socket-security
Copy link

socket-security bot commented Oct 1, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

Base automatically changed from kw/compile-noir-types-package to kw/add-init-to-noir October 2, 2023 10:19
Base automatically changed from kw/add-init-to-noir to master October 2, 2023 12:38
@kevaundray kevaundray added this pull request to the merge queue Oct 2, 2023
Merged via the queue into master with commit 0a51b17 Oct 2, 2023
22 checks passed
@kevaundray kevaundray deleted the kw/use-pkg-json-for-bb-wrapper branch October 2, 2023 14:38
TomAFrench added a commit that referenced this pull request Oct 3, 2023
* master: (53 commits)
  feat: Nargo test runtime callstacks and assert messages without string matching (#2953)
  chore: Release Noir(0.16.0) (#2908)
  chore: run smart contract verification integration tests inside hardhat (#2957)
  chore: fix publishing workflows (#2926)
  chore: restructure integration tests (#2954)
  fix: Improve error message when multiplying unit values (#2950)
  chore: Perform lazy initialization inside `noir_js` (#2951)
  chore: Make one input public in simple assertion program (#2949)
  chore: use new JS packages in integration tests (#2938)
  fix(println): Enable printing of arrays/strings >2 in fmt strings  (#2947)
  feat(ssa): Multiple slice mergers (#2753)
  fix: fix should_fail_with (#2940)
  feat: Oracle mocker for nargo test (#2928)
  chore: add linting to new packages (#2937)
  feat: Dynamic indexing of non-homogenous slices (#2883)
  chore: Fix barretenberg noir typescript wrapper (#2922)
  chore(ci): Rename Noir.js test job (#2932)
  feat!: Maintain shape of foreign call arguments (#2935)
  chore: add init method to Noir class for web (#2920)
  chore: bump `reqwest` to 0.11.20 (#2931)
  ...
Sakapoi pushed a commit to Sakapoi/noir_fork that referenced this pull request Oct 19, 2023
Co-authored-by: Koby Hall <[email protected]>
Co-authored-by: Tom French <[email protected]>
Co-authored-by: Tom French <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants