Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update yarn.lock file #3064

Merged
merged 4 commits into from
Oct 10, 2023
Merged

chore: update yarn.lock file #3064

merged 4 commits into from
Oct 10, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

yarn.lock is out of sync so I've synced it up again.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench
Copy link
Member Author

TomAFrench commented Oct 10, 2023

Hmm, I'm wanting to check that the lockfile is consistent even if we load from cache. It seems like yarn is refetching packages even if we already have node_modules.

We'll likely have to have a separate workflow to check consistency here so we can run this in parallel to tests.

@TomAFrench TomAFrench mentioned this pull request Oct 10, 2023
5 tasks
@kobyhallx kobyhallx added this pull request to the merge queue Oct 10, 2023
Merged via the queue into master with commit 20a160c Oct 10, 2023
36 of 43 checks passed
@kobyhallx kobyhallx deleted the tf/update-yarn-lock branch October 10, 2023 11:01
TomAFrench added a commit that referenced this pull request Oct 10, 2023
* master: (22 commits)
  chore: Update ACIR artifacts (#3013)
  chore: update yarn.lock file (#3064)
  feat(formatter): add formatter support for array literals (#3061)
  chore(traits): updated the trait_function_calls test to include calls to and from static methods (functions without self) (#3034)
  fix: Parse parenthesized lvalues (#3058)
  feat(acir): Set dynamic array values (#3054)
  fix: change non-constant argument errors from `to_be_radix`  from ICE to proper error (#3048)
  feat: add JS types for ABI and input maps (#3023)
  chore: remove clones in optimizer/transformer code (#3037)
  feat: add conditional compilation of methods based on the underlying field being used  (#3045)
  chore: make `eval_constants` a pure function (#3027)
  chore: Formatter can now handle cast expressions (#3000)
  chore(tests): Rewrite some compile failure tests (#2850)
  feat: pass brillig bytecode to VM by reference (#3030)
  chore(formatter): prettier test diff output via `similar-asserts` (#3046)
  fix: disable modulo for fields (#3009)
  chore: parse fieldless structures (#3021)
  chore: publish to npm nightly (#3029)
  chore(tests): Test trait override of MutableReference of struct (#3011)
  chore: Add a flag to nargo to silence warnings (#3032)
  ...
TomAFrench added a commit that referenced this pull request Oct 12, 2023
Sakapoi pushed a commit to Sakapoi/noir_fork that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants