chore: enhance code formatting for If expressions #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
October 21, 2023 23:23
ghost
marked this pull request as ready for review
|
@jfecher please review this, if you can |
TomAFrench
added a commit
that referenced
this pull request
Oct 24, 2023
* master: chore(docs): Rearrange NoirJS section (#3260) chore(docs): Document `nargo fmt` (#3262) feat(debugger): Print limited source code context (#3217) fix: recompile artefacts from a different noir version (#3248) chore: Update ACIR artifacts (#3263) fix: Show println output before an error occurs in `nargo execute` (#3211) chore(docs): document info codelens (#3252) fix: Impl methods are no longer placed in contracts (#3255) feat(stdlib): optimize constraint counts in sha256/sha512 (#3253) chore: enhance code formatting for If expressions (#3246) feat: Cache debug artifacts (#3133)
TomAFrench
added a commit
that referenced
this pull request
Oct 24, 2023
* master: chore(docs): Rearrange NoirJS section (#3260) chore(docs): Document `nargo fmt` (#3262) feat(debugger): Print limited source code context (#3217) fix: recompile artefacts from a different noir version (#3248) chore: Update ACIR artifacts (#3263) fix: Show println output before an error occurs in `nargo execute` (#3211) chore(docs): document info codelens (#3252) fix: Impl methods are no longer placed in contracts (#3255) feat(stdlib): optimize constraint counts in sha256/sha512 (#3253) chore: enhance code formatting for If expressions (#3246) feat: Cache debug artifacts (#3133)
TomAFrench
added a commit
that referenced
this pull request
Oct 24, 2023
* master: feat: implement euclidean division and signed division in terms of `AcirVar`s (#3230) feat: replace boolean range constraints with arithmetic opcodes (#3234) feat!: Switch to new pedersen implementation (#3151) feat: noir-wasm takes dependency graph (#3213) chore(docs): Rearrange NoirJS section (#3260) chore(docs): Document `nargo fmt` (#3262) feat(debugger): Print limited source code context (#3217) fix: recompile artefacts from a different noir version (#3248) chore: Update ACIR artifacts (#3263) fix: Show println output before an error occurs in `nargo execute` (#3211) chore(docs): document info codelens (#3252) fix: Impl methods are no longer placed in contracts (#3255) feat(stdlib): optimize constraint counts in sha256/sha512 (#3253) chore: enhance code formatting for If expressions (#3246) feat: Cache debug artifacts (#3133)
TomAFrench
added a commit
that referenced
this pull request
Oct 24, 2023
* master: feat: implement euclidean division and signed division in terms of `AcirVar`s (#3230) feat: replace boolean range constraints with arithmetic opcodes (#3234) feat!: Switch to new pedersen implementation (#3151) feat: noir-wasm takes dependency graph (#3213) chore(docs): Rearrange NoirJS section (#3260) chore(docs): Document `nargo fmt` (#3262) feat(debugger): Print limited source code context (#3217) fix: recompile artefacts from a different noir version (#3248) chore: Update ACIR artifacts (#3263) fix: Show println output before an error occurs in `nargo execute` (#3211) chore(docs): document info codelens (#3252) fix: Impl methods are no longer placed in contracts (#3255) feat(stdlib): optimize constraint counts in sha256/sha512 (#3253) chore: enhance code formatting for If expressions (#3246) feat: Cache debug artifacts (#3133)
guipublic
pushed a commit
that referenced
this pull request
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR Checklist
cargo fmton default settings.