Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: build acvm_js for integration tests in parallel #3368

Merged
merged 2 commits into from
Oct 30, 2023
Merged

chore: build acvm_js for integration tests in parallel #3368

merged 2 commits into from
Oct 30, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR builds the acvm_js package in parallel to the other nix packages in the integration test workflow. This should save a few minutes from CI time.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench force-pushed the tf/integration-tests-parallel-acvm-js branch from 36690ac to 35295ef Compare October 30, 2023 22:10
@kevaundray kevaundray added this pull request to the merge queue Oct 30, 2023
Merged via the queue into master with commit fab020c Oct 30, 2023
30 checks passed
@kevaundray kevaundray deleted the tf/integration-tests-parallel-acvm-js branch October 30, 2023 23:59
@ghost ghost mentioned this pull request Oct 31, 2023
Merged
5 tasks
TomAFrench added a commit that referenced this pull request Oct 31, 2023
@TomAFrench
Merge branch 'master' into mv/slice-struct-fields
e58dbba 
* master: (86 commits)
  chore: Add a workflow to build with feature flag (#3378)
  chore: fix for-loop in aztec-library (#3377)
  feat!: return Pedersen structure in stdlib (#3190)
  feat: Manage breakpoints and allow restarting a debugging session (#3325)
  chore: small driver refactors (#3375)
  fix: fixing versioning workflow (#3296)
  feat!: noir-wasm outputs debug symbols (#3317)
  chore: build acvm_js for integration tests in parallel (#3368)
  chore: replace bash with `@actions/github-script` (#3369)
  feat(noir_js): allow providing foreign call handlers in noirJS (#3294)
  feat: Allow traits to have generic functions (#3365)
  chore(ci): ensure that acir artifacts are published on master (#3367)
  chore: cleanup CI workflows to be more consistent (#3366)
  fix: Use pedersen_hash for merkle tree (#3357)
  chore: format `for` stmt (#3333)
  fix!: move mimc to hash submodule (#3361)
  fix: remove sha2_block test (#3360)
  chore: deduplicate dependencies across the workspace (#3356)
  chore: Add links to complete NoirJS app code to the guide (#3359)
  chore: clippy fixes (#3358)
  ...
TomAFrench added a commit that referenced this pull request Oct 31, 2023
@TomAFrench
Merge branch 'mv/slice-struct-fields' into mv/fill-slices-pass
0036938 
* mv/slice-struct-fields: (112 commits)
  chore: Add a workflow to build with feature flag (#3378)
  chore: fix for-loop in aztec-library (#3377)
  feat!: return Pedersen structure in stdlib (#3190)
  feat: Manage breakpoints and allow restarting a debugging session (#3325)
  chore: small driver refactors (#3375)
  fix: fixing versioning workflow (#3296)
  feat!: noir-wasm outputs debug symbols (#3317)
  chore: build acvm_js for integration tests in parallel (#3368)
  chore: replace bash with `@actions/github-script` (#3369)
  feat(noir_js): allow providing foreign call handlers in noirJS (#3294)
  feat: Allow traits to have generic functions (#3365)
  chore(ci): ensure that acir artifacts are published on master (#3367)
  chore: cleanup CI workflows to be more consistent (#3366)
  fix: Use pedersen_hash for merkle tree (#3357)
  chore: format `for` stmt (#3333)
  fix!: move mimc to hash submodule (#3361)
  fix: remove sha2_block test (#3360)
  chore: deduplicate dependencies across the workspace (#3356)
  chore: Add links to complete NoirJS app code to the guide (#3359)
  chore: clippy fixes (#3358)
  ...
TomAFrench added a commit that referenced this pull request Oct 31, 2023
@TomAFrench
Merge branch 'master' into phated/lsp-wasm
02f58c7 
* master: (61 commits)
  feat: Add generic count check for trait methods (#3382)
  feat!: avoid integer overflows (#2713)
  chore: Add a workflow to build with feature flag (#3378)
  chore: fix for-loop in aztec-library (#3377)
  feat!: return Pedersen structure in stdlib (#3190)
  feat: Manage breakpoints and allow restarting a debugging session (#3325)
  chore: small driver refactors (#3375)
  fix: fixing versioning workflow (#3296)
  feat!: noir-wasm outputs debug symbols (#3317)
  chore: build acvm_js for integration tests in parallel (#3368)
  chore: replace bash with `@actions/github-script` (#3369)
  feat(noir_js): allow providing foreign call handlers in noirJS (#3294)
  feat: Allow traits to have generic functions (#3365)
  chore(ci): ensure that acir artifacts are published on master (#3367)
  chore: cleanup CI workflows to be more consistent (#3366)
  fix: Use pedersen_hash for merkle tree (#3357)
  chore: format `for` stmt (#3333)
  fix!: move mimc to hash submodule (#3361)
  fix: remove sha2_block test (#3360)
  chore: deduplicate dependencies across the workspace (#3356)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @kevaundray