Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename acir opcode from pedersen to pedersen_commitment #3836

Merged
merged 2 commits into from
Dec 17, 2023

Conversation

kevaundray
Copy link
Contributor

Description

Previously was a breaking change to backends, which is why it was delayed. Since we now no longer support partial backeds, this is not a breaking change as we are not reading an info.json file anymore, or more precisely we are not matching on the opcodes_supported field

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray
Copy link
Contributor Author

kevaundray commented Dec 16, 2023

Install Yarn dependencies step in the workflow seems to have gotten very flaky

@TomAFrench TomAFrench added this pull request to the merge queue Dec 17, 2023
Merged via the queue into master with commit 114be2f Dec 17, 2023
30 checks passed
@TomAFrench TomAFrench deleted the kw/rename-pedersen-to-pedersen-commitment branch December 17, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants