Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Test for printing array of strings #4389

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

vezenovm
Copy link
Contributor

Description

Problem*

Resolves #2903

Summary*

I added a function regression_2903 to the debug_logs test that shows we can now accurately print arrays of strings. This was fixed in previous formatting work. I also removed std:: prefixes from println now that we have a prelude.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

Changes to circuit sizes

Generated at commit: d2466c3b5b4d445da94f44ecbaf2579b66d1a47a, compared to commit: 0a1d109f478c997da5c43876fd12464af638bb15

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
debug_logs +3 ❌ +8.82% 0 ➖ 0.00%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
debug_logs 37 (+3) +8.82% 10 (0) 0.00%

@jfecher jfecher added this pull request to the merge queue Feb 15, 2024
Merged via the queue into master with commit 1fbc6ab Feb 15, 2024
42 checks passed
@jfecher jfecher deleted the mv/regression_2903 branch February 15, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot print array of strings
2 participants