Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add as_slice builtin function, add execution test #4523

Merged
merged 24 commits into from
Mar 15, 2024
Merged

feat: add as_slice builtin function, add execution test #4523

merged 24 commits into from
Mar 15, 2024

Commits on Mar 11, 2024

  1. add as_slice builtin function, add execution test

    @michaeljklein
    michaeljklein committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    d986bfc View commit details
    Browse the repository at this point in the history

  2. wip debugging test failures, add dynamic array case to test

    @michaeljklein
    michaeljklein committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    462af64 View commit details
    Browse the repository at this point in the history

  3. wip debugging error on valid index of result of as_slice

    @michaeljklein
    michaeljklein committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    2b749e1 View commit details
    Browse the repository at this point in the history

  4. update can_omit_element_sizes_array

    @vezenovm
    vezenovm committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    3da8474 View commit details
    Browse the repository at this point in the history

  5. remove dbg calls and cleanup, add brillig implementation for AsSlice,… 

    … wip implementing convert_ssa_as_slice
    @michaeljklein
    michaeljklein committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    197fd77 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. wip debugging brillig as_slice implementation, rewrote implementation… 

    … to match similar ones, recreated debugger error in execution test
    @michaeljklein
    michaeljklein committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    a5f7d9e View commit details
    Browse the repository at this point in the history

  2. wip debugging brillig slice access error, fixed wrong initialization … 

    …of brillig length variable
    @michaeljklein
    michaeljklein committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    e8637a5 View commit details
    Browse the repository at this point in the history

  3. wip debugging: cleanup for second pair of eyes

    @michaeljklein
    michaeljklein committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    efa81db View commit details
    Browse the repository at this point in the history

  4. got brillig tests passing using version of convert_ssa_array_set, cle… 

    …anup as_slice test
    @michaeljklein
    michaeljklein committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    84cfbc3 View commit details
    Browse the repository at this point in the history

  5. remove debugging return

    @michaeljklein
    michaeljklein committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    c29add0 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into michaeljklein/as-slice-builtin

    @michaeljklein
    michaeljklein authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    5be64bd View commit details
    Browse the repository at this point in the history

  7. cargo clippy / fmt

    @michaeljklein
    michaeljklein committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    fecda34 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. fix destination length init in brillig as_slice implementation, split… 

    … out brillig and regular as_slice tests, cargo fmt/clippy
    @michaeljklein
    michaeljklein committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    b6feea0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into michaeljklein/as-slice-builtin

    @michaeljklein
    michaeljklein authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    e940103 View commit details
    Browse the repository at this point in the history

  3. combine convert_ssa_as_slice with convert_ssa_array_set to pull in re… 

    …ference counting changes on master, cargo clippy / fmt
    @michaeljklein
    michaeljklein committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    269bdda View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into michaeljklein/as-slice-builtin

    @michaeljklein
    michaeljklein authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    e5da158 View commit details
    Browse the repository at this point in the history

  5. move as_slice logic out of convert_ssa_array_set

    @michaeljklein
    michaeljklein committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f66772b View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Merge branch 'master' into michaeljklein/as-slice-builtin

    @michaeljklein
    michaeljklein authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    214229e View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Merge branch 'master' into michaeljklein/as-slice-builtin

    @michaeljklein
    michaeljklein authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    10d97e6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into michaeljklein/as-slice-builtin

    @michaeljklein
    michaeljklein authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    e938872 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into michaeljklein/as-slice-builtin

    @michaeljklein
    michaeljklein authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    27ff4f0 View commit details
    Browse the repository at this point in the history

  4. remove method string from ssa generation function (panic will unwind … 

    …stack)
    @michaeljklein
    michaeljklein committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    0f33218 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into michaeljklein/as-slice-builtin

    @michaeljklein
    michaeljklein authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    fe6156d View commit details
    Browse the repository at this point in the history

  6. Update compiler/noirc_evaluator/src/ssa/acir_gen/mod.rs 

    Co-authored-by: Maxim Vezenov <[email protected]>
    @michaeljklein @vezenovm
    michaeljklein and vezenovm authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    c1ec91f View commit details
    Browse the repository at this point in the history