feat: Sync from aztec-packages #4811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This starts work towards #3907 but is only the breaking serialization change. Codegen and evaluation will come in a follow-up. This PR is purely additive and does not remove the current way we do Brillig gen during ACIR gen. Codegen for normal Brillig functions is working in my follow-up, however, removing the existing Brillig opcode will most likely have to come once we settle on how to [handle the brillig std lib](noir-lang/acvm#471) as we are currently generating code such as calculating a quotient during ACIR gen. --------- Co-authored-by: Tom French <[email protected]>
github-actions
bot
added
the
documentation
This PR adds revert data for user-defined messages in the TRAP opcode. Not all messages are returned as revert data, since compiler intrinsic messages are spammed all over SSA and codegening revert data for all those makes brillig function size blow up and impacts performance in a hard way due to deserializing load. This is currently only for static assert messages, since dynamic ones are implemented as an oracle and probably need a rework to be able to return them as revert data. --------- Co-authored-by: Maxim Vezenov <[email protected]>
This PR adds revert data for user-defined messages in the TRAP opcode. Not all messages are returned as revert data, since compiler intrinsic messages are spammed all over SSA and codegening revert data for all those makes brillig function size blow up and impacts performance in a hard way due to deserializing load. This is currently only for static assert messages, since dynamic ones are implemented as an oracle and probably need a rework to be able to return them as revert data. --------- Co-authored-by: Maxim Vezenov <[email protected]>
…nown (AztecProtocol/aztec-packages#5620) This PR enforces the sizes of inputs/outputs of blackbox functions to remove some runtime checks and allocations. --------- Co-authored-by: guipublic <[email protected]> Co-authored-by: vezenovm <[email protected]>
…nown (AztecProtocol/aztec-packages#5620) This PR enforces the sizes of inputs/outputs of blackbox functions to remove some runtime checks and allocations. --------- Co-authored-by: guipublic <[email protected]> Co-authored-by: vezenovm <[email protected]>
This is a breaking change because it will change the acir opcode compiled by Noir. If they are not updated, proving and verification will fail. --------- Co-authored-by: Tom French <[email protected]>
This is a breaking change because it will change the acir opcode compiled by Noir. If they are not updated, proving and verification will fail. --------- Co-authored-by: Tom French <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated pull of Noir development from aztec-packages.
BEGIN_COMMIT_OVERRIDE
feat!: change backend width to 4 (AztecProtocol/aztec-packages#5374)
feat!: Use fixed size arrays in black box functions where sizes are known (AztecProtocol/aztec-packages#5620)
feat!: trap with revert data (AztecProtocol/aztec-packages#5732)
feat: impl of missing functionality in new key store (AztecProtocol/aztec-packages#5750)
feat(acir)!: BrilligCall opcode (AztecProtocol/aztec-packages#5709)
END_COMMIT_OVERRIDE