fix: handle slice of array type #5297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
reviewed
Jun 20, 2024
Comment on lines
+220
to
+222
| // A literal slice can be an array or a slice, | ||
| // however we convert the array into a slice because printable types | ||
| // do not handle slice array properly. |
There was a problem hiding this comment.
Can you elaborate on this comment? A literal slice should only be a slice and never an array since we removed the polymorphism a while back
There was a problem hiding this comment.
Perhaps the issue is with modulus_be_bytes and possibly other builtin functions returning arrays when they should return slices or vice-versa
|
This error is likely just a consequence of this issue: #5278 |
Agreed. We should test this PR again after that one merges. If it is fixed we can close it. |
|
@guipublic The test program in this PR now passes in master so I think we can just close this PR |
|
closing as fixed by #5297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #5245
Summary*
Add support of slices of array type
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.