fix: Fix issue with unresolved results

compiler/noirc_evaluator/src/ssa/checks/check_for_underconstrained_values.rs

@@ -15,12 +15,12 @@
 impl Ssa {
     /// Go through each top-level non-brillig function and detect if it has independent subgraphs
     #[tracing::instrument(level = "trace", skip(self))]
     pub(crate) fn check_for_underconstrained_values(&mut self) -> Vec<SsaReport> {
         let mut warnings: Vec<SsaReport> = Vec::new();
         for function in self.functions.values() {
             match function.runtime() {
                 RuntimeType::Acir { .. } => {
                     warnings.extend(check_for_underconstrained_values_within_function(
                         function,
                         &self.functions,
                     ));
@@ -33,7 +33,7 @@
 }
 
 /// Detect independent subgraphs (not connected to function inputs or outputs) and return a vector of bug reports if some are found
 fn check_for_underconstrained_values_within_function(
     function: &Function,
     all_functions: &BTreeMap<FunctionId, Function>,
 ) -> Vec<SsaReport> {
@@ -105,7 +105,15 @@
             .iter()
             .chain(function.returns())
             .filter(|id| function.dfg.get_numeric_constant(**id).is_none())
-            .copied();
+            .copied()
+            .chain(
+                function
+                    .parameters()
+                    .iter()
+                    .chain(function.returns())
+                    .filter(|id| function.dfg.get_numeric_constant(**id).is_none())
+                    .map(|value_id| function.dfg.resolve(*value_id)),
+            );
 
         let mut connected_sets_indices: HashSet<usize> = HashSet::new();
 
@@ -170,12 +178,14 @@
             function.dfg[*instruction].for_each_value(|value_id| {
                 if function.dfg.get_numeric_constant(value_id).is_none() {
                     instruction_arguments_and_results.insert(value_id);
+                    instruction_arguments_and_results.insert(function.dfg.resolve(value_id));
                 }
             });
             // And non-constant results
             for value_id in function.dfg.instruction_results(*instruction).iter() {
                 if function.dfg.get_numeric_constant(*value_id).is_none() {
                     instruction_arguments_and_results.insert(*value_id);
+                    instruction_arguments_and_results.insert(function.dfg.resolve(*value_id));
                 }
             }
 
@@ -360,7 +370,7 @@
         builder.terminate_with_return(vec![v2]);
 
         let mut ssa = builder.finish();
         let ssa_level_warnings = ssa.check_for_underconstrained_values();
         assert_eq!(ssa_level_warnings.len(), 0);
     }
 
@@ -405,7 +415,7 @@
         let v2 = builder.insert_binary(v0, BinaryOp::Add, v1);
         builder.terminate_with_return(vec![v2]);
         let mut ssa = builder.finish();
         let ssa_level_warnings = ssa.check_for_underconstrained_values();
         assert_eq!(ssa_level_warnings.len(), 1);
     }
 }