Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: LSP inlay hints for let and global #5510

Merged
merged 17 commits into from
Jul 17, 2024
Merged

feat: LSP inlay hints for let and global #5510

merged 17 commits into from
Jul 17, 2024

Commits on Jul 15, 2024

  1. let "go to definition" find type where it's defined

    @asterite
    asterite committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f69488a View commit details
    Browse the repository at this point in the history

  2. feat: LSP inlay hints for let/global types

    @asterite
    asterite committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    2facc5a View commit details
    Browse the repository at this point in the history

  3. Type inlay hints now link and have hover info

    @asterite
    asterite committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f590d0b View commit details
    Browse the repository at this point in the history

  4. Collect hints in let's expression

    @asterite
    asterite committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f4e3efd View commit details
    Browse the repository at this point in the history

  5. Only compute inlay hints for asked range

    @asterite
    asterite committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    b9113fe View commit details
    Browse the repository at this point in the history

  6. Add a couple of tests

    @asterite
    asterite committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    77a3a6a View commit details
    Browse the repository at this point in the history

  7. Remove TODOs

    @asterite
    asterite committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    778fefd View commit details
    Browse the repository at this point in the history

  8. clippy

    @asterite
    asterite committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f9501c9 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into ab/lsp-inlay-type-hints

    @asterite
    asterite authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    c4cfe18 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into ab/lsp-inlay-type-hints

    @TomAFrench
    TomAFrench authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    3742981 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Tom French <[email protected]>
    @asterite @TomAFrench
    asterite and TomAFrench authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    ad4f7bf View commit details
    Browse the repository at this point in the history

  2. Let InlayHintCollector only refer to things it needs

    @asterite
    asterite committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    982bed2 View commit details
    Browse the repository at this point in the history

  3. Pass files to some functions to avoid passing self

    @asterite
    asterite committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    0976f05 View commit details
    Browse the repository at this point in the history

  4. Don't panic on unexpected pattern for reference 

    Instead of blocking entire inlay hints functionality for a file,
let's make it work in most cases. Then if we notice some hints are
missing we can capture an issue and solve it.
    @asterite
    asterite committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    7737743 View commit details
    Browse the repository at this point in the history

  5. Also show inlay hints for for variable

    @asterite
    asterite committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    ba6ef55 View commit details
    Browse the repository at this point in the history

  6. Add a test that it works for global variables

    @asterite
    asterite committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    2d32f7c View commit details
    Browse the repository at this point in the history

  7. clippy

    @asterite
    asterite committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    375e3d0 View commit details
    Browse the repository at this point in the history