Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check argument count and types on attribute function callback #5921

Merged
merged 9 commits into from
Sep 4, 2024
Merged

feat: check argument count and types on attribute function callback #5921

merged 9 commits into from
Sep 4, 2024

Commits on Sep 4, 2024

  1. fix: error if attribute function doesn't have at least one argument

    @asterite
    asterite committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f77c782 View commit details
    Browse the repository at this point in the history

  2. Error on attribute function arg type mismatch

    @asterite
    asterite committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    8e6ec6a View commit details
    Browse the repository at this point in the history

  3. Unify types, don't check equality

    @asterite
    asterite committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    44a8902 View commit details
    Browse the repository at this point in the history

  4. Simplify Type::unify

    @asterite
    asterite committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    16124e6 View commit details
    Browse the repository at this point in the history

  5. Keep custom attribute span, but also track where the name starts

    @asterite
    asterite committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    42e977a View commit details
    Browse the repository at this point in the history

  6. Trait types were already checked

    @asterite
    asterite committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7ab7200 View commit details
    Browse the repository at this point in the history

  7. Track attribute contents span

    @asterite
    asterite committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3c97dd4 View commit details
    Browse the repository at this point in the history

  8. Fix test

    @asterite
    asterite committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    28ca42a View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into ab/comptime-attribute-call-check-params

    @asterite
    asterite committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    84f54e8 View commit details
    Browse the repository at this point in the history