-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: visibility for impl methods #6261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
changed the title
feat: visibility for impl methods
fix: visibility for impl methods
Oct 9, 2024
jfecher
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing, otherwise LGTM
jfecher
approved these changes
Oct 9, 2024
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 10, 2024
feat: Add `checked_transmute` (noir-lang/noir#6262) feat!: kind size checks (noir-lang/noir#6137) feat: don't crash LSP when there are errors resolving the workspace (noir-lang/noir#6257) fix: don't warn on unuse global if it has an abi annotation (noir-lang/noir#6258) fix: don't warn on unused struct that has an abi annotation (noir-lang/noir#6254) feat: don't suggest private struct fields in LSP (noir-lang/noir#6256) feat: visibility for struct fields (noir-lang/noir#6221) fix: handle dfg databus in SSA normalization (noir-lang/noir#6249) fix: homogeneous input points for EC ADD (noir-lang/noir#6241) chore: add regression test for #5756 (noir-lang/noir#5770) feat: allow `unconstrained` after visibility (noir-lang/noir#6246) feat: optimize `Quoted::as_expr` by parsing just once (noir-lang/noir#6237) fix(frontend): Do not warn when a nested struct is provided as input to main (noir-lang/noir#6239) fix!: Change tag attributes to require a ' prefix (noir-lang/noir#6235) feat: recover from '=' instead of ':' in struct constructor/pattern (noir-lang/noir#6236)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 10, 2024
feat: Add `checked_transmute` (noir-lang/noir#6262) feat!: kind size checks (noir-lang/noir#6137) feat: don't crash LSP when there are errors resolving the workspace (noir-lang/noir#6257) fix: don't warn on unuse global if it has an abi annotation (noir-lang/noir#6258) fix: don't warn on unused struct that has an abi annotation (noir-lang/noir#6254) feat: don't suggest private struct fields in LSP (noir-lang/noir#6256) feat: visibility for struct fields (noir-lang/noir#6221) fix: handle dfg databus in SSA normalization (noir-lang/noir#6249) fix: homogeneous input points for EC ADD (noir-lang/noir#6241) chore: add regression test for #5756 (noir-lang/noir#5770) feat: allow `unconstrained` after visibility (noir-lang/noir#6246) feat: optimize `Quoted::as_expr` by parsing just once (noir-lang/noir#6237) fix(frontend): Do not warn when a nested struct is provided as input to main (noir-lang/noir#6239) fix!: Change tag attributes to require a ' prefix (noir-lang/noir#6235) feat: recover from '=' instead of ':' in struct constructor/pattern (noir-lang/noir#6236)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 10, 2024
…ry (noir-lang/noir#6273) feat: remove byte decomposition in `compute_decomposition` (noir-lang/noir#6159) fix: address inactive public key check in `verify_signature_noir` (noir-lang/noir#6270) feat(test): Fuzz test poseidon2 hash equivalence (noir-lang/noir#6265) fix!: Integer division is not the inverse of integer multiplication (noir-lang/noir#6243) feat(perf): Flamegraphs for test program execution benchmarks (noir-lang/noir#6253) fix: visibility for impl methods (noir-lang/noir#6261) feat: Add `checked_transmute` (noir-lang/noir#6262) feat!: kind size checks (noir-lang/noir#6137) feat: don't crash LSP when there are errors resolving the workspace (noir-lang/noir#6257) fix: don't warn on unuse global if it has an abi annotation (noir-lang/noir#6258) fix: don't warn on unused struct that has an abi annotation (noir-lang/noir#6254) feat: don't suggest private struct fields in LSP (noir-lang/noir#6256) feat: visibility for struct fields (noir-lang/noir#6221) fix: handle dfg databus in SSA normalization (noir-lang/noir#6249) fix: homogeneous input points for EC ADD (noir-lang/noir#6241) chore: add regression test for #5756 (noir-lang/noir#5770) feat: allow `unconstrained` after visibility (noir-lang/noir#6246) feat: optimize `Quoted::as_expr` by parsing just once (noir-lang/noir#6237) fix(frontend): Do not warn when a nested struct is provided as input to main (noir-lang/noir#6239) fix!: Change tag attributes to require a ' prefix (noir-lang/noir#6235) feat: recover from '=' instead of ':' in struct constructor/pattern (noir-lang/noir#6236)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 10, 2024
…g/noir#6273) feat: remove byte decomposition in `compute_decomposition` (noir-lang/noir#6159) fix: address inactive public key check in `verify_signature_noir` (noir-lang/noir#6270) feat(test): Fuzz test poseidon2 hash equivalence (noir-lang/noir#6265) fix!: Integer division is not the inverse of integer multiplication (noir-lang/noir#6243) feat(perf): Flamegraphs for test program execution benchmarks (noir-lang/noir#6253) fix: visibility for impl methods (noir-lang/noir#6261) feat: Add `checked_transmute` (noir-lang/noir#6262) feat!: kind size checks (noir-lang/noir#6137) feat: don't crash LSP when there are errors resolving the workspace (noir-lang/noir#6257) fix: don't warn on unuse global if it has an abi annotation (noir-lang/noir#6258) fix: don't warn on unused struct that has an abi annotation (noir-lang/noir#6254) feat: don't suggest private struct fields in LSP (noir-lang/noir#6256) feat: visibility for struct fields (noir-lang/noir#6221) fix: handle dfg databus in SSA normalization (noir-lang/noir#6249) fix: homogeneous input points for EC ADD (noir-lang/noir#6241) chore: add regression test for #5756 (noir-lang/noir#5770) feat: allow `unconstrained` after visibility (noir-lang/noir#6246) feat: optimize `Quoted::as_expr` by parsing just once (noir-lang/noir#6237) fix(frontend): Do not warn when a nested struct is provided as input to main (noir-lang/noir#6239) fix!: Change tag attributes to require a ' prefix (noir-lang/noir#6235) feat: recover from '=' instead of ':' in struct constructor/pattern (noir-lang/noir#6236)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 11, 2024
…oir-lang/noir#6279) feat(test): Fuzz poseidon hases against an external library (noir-lang/noir#6273) feat: remove byte decomposition in `compute_decomposition` (noir-lang/noir#6159) fix: address inactive public key check in `verify_signature_noir` (noir-lang/noir#6270) feat(test): Fuzz test poseidon2 hash equivalence (noir-lang/noir#6265) fix!: Integer division is not the inverse of integer multiplication (noir-lang/noir#6243) feat(perf): Flamegraphs for test program execution benchmarks (noir-lang/noir#6253) fix: visibility for impl methods (noir-lang/noir#6261) feat: Add `checked_transmute` (noir-lang/noir#6262) feat!: kind size checks (noir-lang/noir#6137) feat: don't crash LSP when there are errors resolving the workspace (noir-lang/noir#6257) fix: don't warn on unuse global if it has an abi annotation (noir-lang/noir#6258) fix: don't warn on unused struct that has an abi annotation (noir-lang/noir#6254) feat: don't suggest private struct fields in LSP (noir-lang/noir#6256) feat: visibility for struct fields (noir-lang/noir#6221) fix: handle dfg databus in SSA normalization (noir-lang/noir#6249) fix: homogeneous input points for EC ADD (noir-lang/noir#6241) chore: add regression test for #5756 (noir-lang/noir#5770) feat: allow `unconstrained` after visibility (noir-lang/noir#6246) feat: optimize `Quoted::as_expr` by parsing just once (noir-lang/noir#6237) fix(frontend): Do not warn when a nested struct is provided as input to main (noir-lang/noir#6239) fix!: Change tag attributes to require a ' prefix (noir-lang/noir#6235) feat: recover from '=' instead of ':' in struct constructor/pattern (noir-lang/noir#6236)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 11, 2024
…ir#6279) feat(test): Fuzz poseidon hases against an external library (noir-lang/noir#6273) feat: remove byte decomposition in `compute_decomposition` (noir-lang/noir#6159) fix: address inactive public key check in `verify_signature_noir` (noir-lang/noir#6270) feat(test): Fuzz test poseidon2 hash equivalence (noir-lang/noir#6265) fix!: Integer division is not the inverse of integer multiplication (noir-lang/noir#6243) feat(perf): Flamegraphs for test program execution benchmarks (noir-lang/noir#6253) fix: visibility for impl methods (noir-lang/noir#6261) feat: Add `checked_transmute` (noir-lang/noir#6262) feat!: kind size checks (noir-lang/noir#6137) feat: don't crash LSP when there are errors resolving the workspace (noir-lang/noir#6257) fix: don't warn on unuse global if it has an abi annotation (noir-lang/noir#6258) fix: don't warn on unused struct that has an abi annotation (noir-lang/noir#6254) feat: don't suggest private struct fields in LSP (noir-lang/noir#6256) feat: visibility for struct fields (noir-lang/noir#6221) fix: handle dfg databus in SSA normalization (noir-lang/noir#6249) fix: homogeneous input points for EC ADD (noir-lang/noir#6241) chore: add regression test for #5756 (noir-lang/noir#5770) feat: allow `unconstrained` after visibility (noir-lang/noir#6246) feat: optimize `Quoted::as_expr` by parsing just once (noir-lang/noir#6237) fix(frontend): Do not warn when a nested struct is provided as input to main (noir-lang/noir#6239) fix!: Change tag attributes to require a ' prefix (noir-lang/noir#6235) feat: recover from '=' instead of ':' in struct constructor/pattern (noir-lang/noir#6236)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 12, 2024
feat(improve): Remove scan through globals (noir-lang/noir#6282) feat: show LSP diagnostic related information (noir-lang/noir#6277) feat: trait inheritance (noir-lang/noir#6252) feat: optimize reading a workspace's files (noir-lang/noir#6281) fix: prevent compiler panic when popping from empty slices (noir-lang/noir#6274) feat(test): Include the PoseidonHasher in the fuzzing (noir-lang/noir#6280) feat: slightly improve "unexpected token" error message (noir-lang/noir#6279) feat(test): Fuzz poseidon hases against an external library (noir-lang/noir#6273) feat: remove byte decomposition in `compute_decomposition` (noir-lang/noir#6159) fix: address inactive public key check in `verify_signature_noir` (noir-lang/noir#6270) feat(test): Fuzz test poseidon2 hash equivalence (noir-lang/noir#6265) fix!: Integer division is not the inverse of integer multiplication (noir-lang/noir#6243) feat(perf): Flamegraphs for test program execution benchmarks (noir-lang/noir#6253) fix: visibility for impl methods (noir-lang/noir#6261) feat: Add `checked_transmute` (noir-lang/noir#6262) feat!: kind size checks (noir-lang/noir#6137) feat: don't crash LSP when there are errors resolving the workspace (noir-lang/noir#6257) fix: don't warn on unuse global if it has an abi annotation (noir-lang/noir#6258) fix: don't warn on unused struct that has an abi annotation (noir-lang/noir#6254) feat: don't suggest private struct fields in LSP (noir-lang/noir#6256) feat: visibility for struct fields (noir-lang/noir#6221) fix: handle dfg databus in SSA normalization (noir-lang/noir#6249) fix: homogeneous input points for EC ADD (noir-lang/noir#6241) chore: add regression test for #5756 (noir-lang/noir#5770) feat: allow `unconstrained` after visibility (noir-lang/noir#6246) feat: optimize `Quoted::as_expr` by parsing just once (noir-lang/noir#6237) fix(frontend): Do not warn when a nested struct is provided as input to main (noir-lang/noir#6239) fix!: Change tag attributes to require a ' prefix (noir-lang/noir#6235) feat: recover from '=' instead of ':' in struct constructor/pattern (noir-lang/noir#6236)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 12, 2024
feat(improve): Remove scan through globals (noir-lang/noir#6282) feat: show LSP diagnostic related information (noir-lang/noir#6277) feat: trait inheritance (noir-lang/noir#6252) feat: optimize reading a workspace's files (noir-lang/noir#6281) fix: prevent compiler panic when popping from empty slices (noir-lang/noir#6274) feat(test): Include the PoseidonHasher in the fuzzing (noir-lang/noir#6280) feat: slightly improve "unexpected token" error message (noir-lang/noir#6279) feat(test): Fuzz poseidon hases against an external library (noir-lang/noir#6273) feat: remove byte decomposition in `compute_decomposition` (noir-lang/noir#6159) fix: address inactive public key check in `verify_signature_noir` (noir-lang/noir#6270) feat(test): Fuzz test poseidon2 hash equivalence (noir-lang/noir#6265) fix!: Integer division is not the inverse of integer multiplication (noir-lang/noir#6243) feat(perf): Flamegraphs for test program execution benchmarks (noir-lang/noir#6253) fix: visibility for impl methods (noir-lang/noir#6261) feat: Add `checked_transmute` (noir-lang/noir#6262) feat!: kind size checks (noir-lang/noir#6137) feat: don't crash LSP when there are errors resolving the workspace (noir-lang/noir#6257) fix: don't warn on unuse global if it has an abi annotation (noir-lang/noir#6258) fix: don't warn on unused struct that has an abi annotation (noir-lang/noir#6254) feat: don't suggest private struct fields in LSP (noir-lang/noir#6256) feat: visibility for struct fields (noir-lang/noir#6221) fix: handle dfg databus in SSA normalization (noir-lang/noir#6249) fix: homogeneous input points for EC ADD (noir-lang/noir#6241) chore: add regression test for #5756 (noir-lang/noir#5770) feat: allow `unconstrained` after visibility (noir-lang/noir#6246) feat: optimize `Quoted::as_expr` by parsing just once (noir-lang/noir#6237) fix(frontend): Do not warn when a nested struct is provided as input to main (noir-lang/noir#6239) fix!: Change tag attributes to require a ' prefix (noir-lang/noir#6235) feat: recover from '=' instead of ':' in struct constructor/pattern (noir-lang/noir#6236)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 13, 2024
feat(improve): Remove scan through globals (noir-lang/noir#6282) feat: show LSP diagnostic related information (noir-lang/noir#6277) feat: trait inheritance (noir-lang/noir#6252) feat: optimize reading a workspace's files (noir-lang/noir#6281) fix: prevent compiler panic when popping from empty slices (noir-lang/noir#6274) feat(test): Include the PoseidonHasher in the fuzzing (noir-lang/noir#6280) feat: slightly improve "unexpected token" error message (noir-lang/noir#6279) feat(test): Fuzz poseidon hases against an external library (noir-lang/noir#6273) feat: remove byte decomposition in `compute_decomposition` (noir-lang/noir#6159) fix: address inactive public key check in `verify_signature_noir` (noir-lang/noir#6270) feat(test): Fuzz test poseidon2 hash equivalence (noir-lang/noir#6265) fix!: Integer division is not the inverse of integer multiplication (noir-lang/noir#6243) feat(perf): Flamegraphs for test program execution benchmarks (noir-lang/noir#6253) fix: visibility for impl methods (noir-lang/noir#6261) feat: Add `checked_transmute` (noir-lang/noir#6262) feat!: kind size checks (noir-lang/noir#6137) feat: don't crash LSP when there are errors resolving the workspace (noir-lang/noir#6257) fix: don't warn on unuse global if it has an abi annotation (noir-lang/noir#6258) fix: don't warn on unused struct that has an abi annotation (noir-lang/noir#6254) feat: don't suggest private struct fields in LSP (noir-lang/noir#6256) feat: visibility for struct fields (noir-lang/noir#6221) fix: handle dfg databus in SSA normalization (noir-lang/noir#6249) fix: homogeneous input points for EC ADD (noir-lang/noir#6241) chore: add regression test for #5756 (noir-lang/noir#5770) feat: allow `unconstrained` after visibility (noir-lang/noir#6246) feat: optimize `Quoted::as_expr` by parsing just once (noir-lang/noir#6237) fix(frontend): Do not warn when a nested struct is provided as input to main (noir-lang/noir#6239) fix!: Change tag attributes to require a ' prefix (noir-lang/noir#6235) feat: recover from '=' instead of ':' in struct constructor/pattern (noir-lang/noir#6236)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 13, 2024
feat(improve): Remove scan through globals (noir-lang/noir#6282) feat: show LSP diagnostic related information (noir-lang/noir#6277) feat: trait inheritance (noir-lang/noir#6252) feat: optimize reading a workspace's files (noir-lang/noir#6281) fix: prevent compiler panic when popping from empty slices (noir-lang/noir#6274) feat(test): Include the PoseidonHasher in the fuzzing (noir-lang/noir#6280) feat: slightly improve "unexpected token" error message (noir-lang/noir#6279) feat(test): Fuzz poseidon hases against an external library (noir-lang/noir#6273) feat: remove byte decomposition in `compute_decomposition` (noir-lang/noir#6159) fix: address inactive public key check in `verify_signature_noir` (noir-lang/noir#6270) feat(test): Fuzz test poseidon2 hash equivalence (noir-lang/noir#6265) fix!: Integer division is not the inverse of integer multiplication (noir-lang/noir#6243) feat(perf): Flamegraphs for test program execution benchmarks (noir-lang/noir#6253) fix: visibility for impl methods (noir-lang/noir#6261) feat: Add `checked_transmute` (noir-lang/noir#6262) feat!: kind size checks (noir-lang/noir#6137) feat: don't crash LSP when there are errors resolving the workspace (noir-lang/noir#6257) fix: don't warn on unuse global if it has an abi annotation (noir-lang/noir#6258) fix: don't warn on unused struct that has an abi annotation (noir-lang/noir#6254) feat: don't suggest private struct fields in LSP (noir-lang/noir#6256) feat: visibility for struct fields (noir-lang/noir#6221) fix: handle dfg databus in SSA normalization (noir-lang/noir#6249) fix: homogeneous input points for EC ADD (noir-lang/noir#6241) chore: add regression test for #5756 (noir-lang/noir#5770) feat: allow `unconstrained` after visibility (noir-lang/noir#6246) feat: optimize `Quoted::as_expr` by parsing just once (noir-lang/noir#6237) fix(frontend): Do not warn when a nested struct is provided as input to main (noir-lang/noir#6239) fix!: Change tag attributes to require a ' prefix (noir-lang/noir#6235) feat: recover from '=' instead of ':' in struct constructor/pattern (noir-lang/noir#6236)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 14, 2024
feat(improve): Remove scan through globals (noir-lang/noir#6282) feat: show LSP diagnostic related information (noir-lang/noir#6277) feat: trait inheritance (noir-lang/noir#6252) feat: optimize reading a workspace's files (noir-lang/noir#6281) fix: prevent compiler panic when popping from empty slices (noir-lang/noir#6274) feat(test): Include the PoseidonHasher in the fuzzing (noir-lang/noir#6280) feat: slightly improve "unexpected token" error message (noir-lang/noir#6279) feat(test): Fuzz poseidon hases against an external library (noir-lang/noir#6273) feat: remove byte decomposition in `compute_decomposition` (noir-lang/noir#6159) fix: address inactive public key check in `verify_signature_noir` (noir-lang/noir#6270) feat(test): Fuzz test poseidon2 hash equivalence (noir-lang/noir#6265) fix!: Integer division is not the inverse of integer multiplication (noir-lang/noir#6243) feat(perf): Flamegraphs for test program execution benchmarks (noir-lang/noir#6253) fix: visibility for impl methods (noir-lang/noir#6261) feat: Add `checked_transmute` (noir-lang/noir#6262) feat!: kind size checks (noir-lang/noir#6137) feat: don't crash LSP when there are errors resolving the workspace (noir-lang/noir#6257) fix: don't warn on unuse global if it has an abi annotation (noir-lang/noir#6258) fix: don't warn on unused struct that has an abi annotation (noir-lang/noir#6254) feat: don't suggest private struct fields in LSP (noir-lang/noir#6256) feat: visibility for struct fields (noir-lang/noir#6221) fix: handle dfg databus in SSA normalization (noir-lang/noir#6249) fix: homogeneous input points for EC ADD (noir-lang/noir#6241) chore: add regression test for #5756 (noir-lang/noir#5770) feat: allow `unconstrained` after visibility (noir-lang/noir#6246) feat: optimize `Quoted::as_expr` by parsing just once (noir-lang/noir#6237) fix(frontend): Do not warn when a nested struct is provided as input to main (noir-lang/noir#6239) fix!: Change tag attributes to require a ' prefix (noir-lang/noir#6235) feat: recover from '=' instead of ':' in struct constructor/pattern (noir-lang/noir#6236)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 14, 2024
feat(improve): Remove scan through globals (noir-lang/noir#6282) feat: show LSP diagnostic related information (noir-lang/noir#6277) feat: trait inheritance (noir-lang/noir#6252) feat: optimize reading a workspace's files (noir-lang/noir#6281) fix: prevent compiler panic when popping from empty slices (noir-lang/noir#6274) feat(test): Include the PoseidonHasher in the fuzzing (noir-lang/noir#6280) feat: slightly improve "unexpected token" error message (noir-lang/noir#6279) feat(test): Fuzz poseidon hases against an external library (noir-lang/noir#6273) feat: remove byte decomposition in `compute_decomposition` (noir-lang/noir#6159) fix: address inactive public key check in `verify_signature_noir` (noir-lang/noir#6270) feat(test): Fuzz test poseidon2 hash equivalence (noir-lang/noir#6265) fix!: Integer division is not the inverse of integer multiplication (noir-lang/noir#6243) feat(perf): Flamegraphs for test program execution benchmarks (noir-lang/noir#6253) fix: visibility for impl methods (noir-lang/noir#6261) feat: Add `checked_transmute` (noir-lang/noir#6262) feat!: kind size checks (noir-lang/noir#6137) feat: don't crash LSP when there are errors resolving the workspace (noir-lang/noir#6257) fix: don't warn on unuse global if it has an abi annotation (noir-lang/noir#6258) fix: don't warn on unused struct that has an abi annotation (noir-lang/noir#6254) feat: don't suggest private struct fields in LSP (noir-lang/noir#6256) feat: visibility for struct fields (noir-lang/noir#6221) fix: handle dfg databus in SSA normalization (noir-lang/noir#6249) fix: homogeneous input points for EC ADD (noir-lang/noir#6241) chore: add regression test for #5756 (noir-lang/noir#5770) feat: allow `unconstrained` after visibility (noir-lang/noir#6246) feat: optimize `Quoted::as_expr` by parsing just once (noir-lang/noir#6237) fix(frontend): Do not warn when a nested struct is provided as input to main (noir-lang/noir#6239) fix!: Change tag attributes to require a ' prefix (noir-lang/noir#6235) feat: recover from '=' instead of ':' in struct constructor/pattern (noir-lang/noir#6236)
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 14, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat(test): Fuzz poseidon hases against an external library (noir-lang/noir#6273) feat: remove byte decomposition in `compute_decomposition` (noir-lang/noir#6159) fix: address inactive public key check in `verify_signature_noir` (noir-lang/noir#6270) feat(test): Fuzz test poseidon2 hash equivalence (noir-lang/noir#6265) fix!: Integer division is not the inverse of integer multiplication (noir-lang/noir#6243) feat(perf): Flamegraphs for test program execution benchmarks (noir-lang/noir#6253) fix: visibility for impl methods (noir-lang/noir#6261) feat: Add `checked_transmute` (noir-lang/noir#6262) feat!: kind size checks (noir-lang/noir#6137) feat: don't crash LSP when there are errors resolving the workspace (noir-lang/noir#6257) fix: don't warn on unuse global if it has an abi annotation (noir-lang/noir#6258) fix: don't warn on unused struct that has an abi annotation (noir-lang/noir#6254) feat: don't suggest private struct fields in LSP (noir-lang/noir#6256) feat: visibility for struct fields (noir-lang/noir#6221) fix: handle dfg databus in SSA normalization (noir-lang/noir#6249) fix: homogeneous input points for EC ADD (noir-lang/noir#6241) chore: add regression test for #5756 (noir-lang/noir#5770) feat: allow `unconstrained` after visibility (noir-lang/noir#6246) feat: optimize `Quoted::as_expr` by parsing just once (noir-lang/noir#6237) fix(frontend): Do not warn when a nested struct is provided as input to main (noir-lang/noir#6239) fix!: Change tag attributes to require a ' prefix (noir-lang/noir#6235) feat: recover from '=' instead of ':' in struct constructor/pattern (noir-lang/noir#6236) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <[email protected]>
AztecBot
added a commit
to AztecProtocol/aztec-nr
that referenced
this pull request
Oct 15, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat(test): Fuzz poseidon hases against an external library (noir-lang/noir#6273) feat: remove byte decomposition in `compute_decomposition` (noir-lang/noir#6159) fix: address inactive public key check in `verify_signature_noir` (noir-lang/noir#6270) feat(test): Fuzz test poseidon2 hash equivalence (noir-lang/noir#6265) fix!: Integer division is not the inverse of integer multiplication (noir-lang/noir#6243) feat(perf): Flamegraphs for test program execution benchmarks (noir-lang/noir#6253) fix: visibility for impl methods (noir-lang/noir#6261) feat: Add `checked_transmute` (noir-lang/noir#6262) feat!: kind size checks (noir-lang/noir#6137) feat: don't crash LSP when there are errors resolving the workspace (noir-lang/noir#6257) fix: don't warn on unuse global if it has an abi annotation (noir-lang/noir#6258) fix: don't warn on unused struct that has an abi annotation (noir-lang/noir#6254) feat: don't suggest private struct fields in LSP (noir-lang/noir#6256) feat: visibility for struct fields (noir-lang/noir#6221) fix: handle dfg databus in SSA normalization (noir-lang/noir#6249) fix: homogeneous input points for EC ADD (noir-lang/noir#6241) chore: add regression test for #5756 (noir-lang/noir#5770) feat: allow `unconstrained` after visibility (noir-lang/noir#6246) feat: optimize `Quoted::as_expr` by parsing just once (noir-lang/noir#6237) fix(frontend): Do not warn when a nested struct is provided as input to main (noir-lang/noir#6239) fix!: Change tag attributes to require a ' prefix (noir-lang/noir#6235) feat: recover from '=' instead of ':' in struct constructor/pattern (noir-lang/noir#6236) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Part of #4515
Apparently in #6179 I only made it work for calls like
foo::Bar::baz()
but no checks were done for method calls (whereself
is involved).Summary
This PR now warns when calling private or
pub(crate)
methods, either on structs or primitive types, when they are not accessible from the current module.We also now don't suggest non-accessible methods from LSP.
Additional Context
I also removed an unused global that was introduced some time ago.
Documentation
Check one:
PR Checklist
cargo fmt
on default settings.