chore(refactor): Remove optional global_id from methods that can get it from the definition #6283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
added a commit
that referenced
this pull request
Oct 11, 2024
…it from the definition (#6283) # Description ## Problem\* Followup to #6282 ## Summary\* Some methods in the `Elaborator` received a `global_id: Option<GlobalId>` and a `definition: DefinitionKind` parameter. We found that `Elaborator::elaborate_let` actually created `definition` to carry the same global ID as it was given, so `global_id: Some(id)` and `definition: DefinitionKind::Global(id)` always carried the same value. We added an [assertion](1d2bd36) that checked that they are never different. The next logical step is to remove the possibility of confusion by only carrying the ID in the definition. ## Additional Context ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Followup to #6282
Summary*
Some methods in the
Elaboratorreceived aglobal_id: Option<GlobalId>and adefinition: DefinitionKindparameter. We found thatElaborator::elaborate_letactually createddefinitionto carry the same global ID as it was given, soglobal_id: Some(id)anddefinition: DefinitionKind::Global(id)always carried the same value. We added an assertion that checked that they are never different.The next logical step is to remove the possibility of confusion by only carrying the ID in the definition.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.