Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement LSP client #3

Merged
merged 6 commits into from
Jun 23, 2023
Merged

feat: Implement LSP client #3

merged 6 commits into from
Jun 23, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Jun 5, 2023

Description

Problem*

Resolves #2

Summary*

This reorganizes the vscode extension and adds an LSP client to communicate with the Nargo LSP.

A lot has changed in the reorganization but this aligns the extension with the common/expected layout. Most of which was taken from the Grain vscode extension that I wrote, which in turn was based on the vscode example layout and documentation.

Additional Context

Prettier should be run on more code in the repo but it resulted in a ton of changes in this diff. We can do it separately.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't examine extension.ts in-depth but this looks generally like what I'd expect from an LSP skeleton.

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bikeshedding but are you happy to use yarn for this? We tend to use this over npm in our other repos.

@phated
Copy link
Contributor Author

phated commented Jun 7, 2023

@TomAFrench Yarn probably makes sense since the rest of aztec uses it. I switched back to npm for personal projects awhile ago because yarn2/3 were so bad (new design requiring a custom patch for each typescript release). Npm added workspaces so it had everything I needed.

@phated phated linked an issue Jun 8, 2023 that may be closed by this pull request
Copy link
Contributor

@kobyhallx kobyhallx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phated phated merged commit 1a4933d into master Jun 23, 2023
@phated phated deleted the phated/extension branch June 23, 2023 16:57
@github-actions github-actions bot mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin icon Implement LSP client
4 participants