Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Optimize Compiled Code" option broken for HIDE_PART_BG .or. HIDE_PART_VALUE #423

Closed
blackeyedpony opened this issue Dec 22, 2023 · 3 comments · Fixed by #424
Closed

"Optimize Compiled Code" option broken for HIDE_PART_BG .or. HIDE_PART_VALUE #423

blackeyedpony opened this issue Dec 22, 2023 · 3 comments · Fixed by #424

Comments

@blackeyedpony
Copy link

blackeyedpony commented Dec 22, 2023

please check this example with "Optimize compiled code" enabled:

on init 

	declare ui_table t[8](2, 2, 100)
	t -> hide :=  HIDE_PART_BG .or. HIDE_PART_VALUE

end on

The problem was introduced around this commit:
Segregate built-in constants from variables in ksp_builtins_data.py (#412) dc4cbe8 EvilDragon [email protected] 30.11.2023, 21:24
The optimise logic tries to convert HIDE_PART_BG into an int.

@mkruselj
Copy link
Collaborator

mkruselj commented Dec 22, 2023

Thanks for the report! I think I have a potential fix. See here.

@mkruselj
Copy link
Collaborator

@blackeyedpony Could you test with current state of master branch? Thanks!

@blackeyedpony
Copy link
Author

Thanks Mario ! I ran a quick test. It works as it should now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants