Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect writing and reading of rref #117

Open
bradh opened this issue Apr 12, 2023 · 0 comments · May be fixed by #118
Open

incorrect writing and reading of rref #117

bradh opened this issue Apr 12, 2023 · 0 comments · May be fixed by #118

Comments

@bradh
Copy link

bradh commented Apr 12, 2023

https://github.com/nokiatech/heif/blob/master/srcs/common/requiredreferencetypesproperty.cpp#L39

and

https://github.com/nokiatech/heif/blob/master/srcs/common/requiredreferencetypesproperty.cpp#L52

are treating the count as a 32 bit unsigned value.

Per ISO/IEC 23008-12:2022 Section 6.5.17.2 "Syntax", reference_type_count is an 8 bit unsigned value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rref: correct size of reference_type_count bradh/heif
1 participant
@bradh