-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work in node 16, TypeError: perf.getEntriesByName is not a function
#18
Comments
The performance API in Node does not match the performance API for the web as documented on MDN (see https://developer.mozilla.org/en-US/docs/Web/API/Performance/getEntriesByName). Although the Node-specific performance API has been around since Node 10, in Node 16 an instance of this class is now bound to the global variable |
Please consider merging the proposed PR and releasing a patch release. Right now, any software that depends on marky cannot be used on Node 16. |
In node 16,
performance
is a global with themark
method (so the hrtime path isn't used), but it does not havegetEntriesByName
(so marky.stop throws an exception). Feature detection is now necessary for all the performance methods used :/marky/src/index.js
Line 31 in 9e43c8e
Originally surfaced in GoogleChrome/lighthouse-ci#596
The text was updated successfully, but these errors were encountered: