Auto-detect cluster type for proper webhook server's hostname #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolar
added
automation
|
This pull request fixes 31 alerts when merging a127c49 into db2c6cd - view on LGTM.com fixed alerts:
|
nolar
force-pushed
the
webhook-auto-servers-tunnels
branch
2 times, most recently
from
c0d513d
to
ce57b60
Compare
Signed-off-by: Sergey Vasilyev <[email protected]>
nolar
force-pushed
the
webhook-auto-servers-tunnels
branch
from
ce57b60
to
171c4b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #708, the webhook server was made specific (and K3d/K3s is configured). However, when tested in the "thorough tests" after the merge, the e2e tests failed on the Minikube cluster — because it has a different magic hostname:
host.minikube.internalinstead ofhost.k3d.internal.To make it work automatically in CI/CD, and in most other cases, this PR adds a feature to automatically detect the cluster type (among the limited list of options: Minikube, K3d/K3s only). Users can also configure auto-tunnel, which will fall back to ngrok if the cluster type cannot be detected; the auto-server will run a simple local server in that case.