Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve circular imports bound to HandlerId #722

Merged
merged 1 commit into from
Mar 27, 2021
Merged

Resolve circular imports bound to HandlerId #722

merged 1 commit into from
Mar 27, 2021

Commits on Mar 27, 2021

  1. Resolve circular imports bound to HandlerId 

    The chain of dependencies this time was (introduced in e89ac21):

* `callbacks` imported `configuration` for the "settings" kwarg.
* `configuration` imported `storage.progress` for its persistence settings.
* `storage.progress` imported `handlers` for only `HandlerId`.
* `handlers` imported `callbacks` for handlers' function types.

The chain is broken at the `progress`->`handlers` dependency: it is now `progress`->`ids`.

This was a frequent problem before, so `HandlerId` deserves its dedicated moduled until all modules are rebalanced (later).

Signed-off-by: Sergey Vasilyev <[email protected]>
    @nolar
    nolar committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    8fb507c View commit details
    Browse the repository at this point in the history