-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Overflow to Clip #6738
Change Overflow to Clip #6738
Conversation
There might be a few more instances where this can be changed, but these are the only ones that I found. |
I am also not 100% on all the side effects of this change, so that might be good to double check |
Would like to see a live example (better codesandbox) where it is used with Swiper |
I got you: CodePen |
@Lucien950 thank you. I will merge a bit later as it can be a breaking change, so this will land into upcoming v10 |
What if one needs overflow-y visible on the ".swiper" now? How to override? |
Using CSS |
Ah, just saw it's with part="container", I'll try, thanks. |
Hi @Lucien950! I was migrating a project from Swiper 8 to 10 and faced some issues regarding this change. I tried my best to reproduce it here: When the overflow was Appreciate your support, if available :) |
@Lucien950 that is weird... maybe browser or window size? I'm seeing this in my Firefox: |
I too see it on firefox. It is also strange that the arrows are not there. Perhaps these two problems are related? |
Yeah, definitely browser-related, it works on Chrome. The arrow does not appear because Swiper seems to believe it has enough space. |
Consider the following situation
Suppose that there is a swiping element horizontally with a few elements, which grown when hovered. When it grows, it exeeds the Y axis overflow.
With overflow hidden, setting
overflow-y
to "visible" does nothing. However setting overflow to clip allows y-overflow to be visible.This is as per the W3 Specification: